Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2918113002: Change default minimum screencast frame rate to zero. (Closed)

Created:
3 years, 6 months ago by Guido Urdaneta
Modified:
3 years, 6 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, miu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change default minimum screencast frame rate to zero. This is causing issues with refresh-interval computations that treat zero as a special value and expect zero as the default minimum, as it was with the old constraints algorithm. BUG=725696 Review-Url: https://codereview.chromium.org/2918113002 Cr-Commit-Position: refs/heads/master@{#476728} Committed: https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/renderer/media/media_stream_constraints_util_video_content.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_constraints_util_video_content_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Guido Urdaneta
Hi, PTAL
3 years, 6 months ago (2017-06-02 10:01:18 UTC) #4
hbos_chromium
lgtm
3 years, 6 months ago (2017-06-02 11:07:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918113002/1
3 years, 6 months ago (2017-06-02 11:55:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309164)
3 years, 6 months ago (2017-06-02 13:34:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918113002/1
3 years, 6 months ago (2017-06-02 16:37:38 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9d5685faf6178778aaec42384e4c3f81890799b5
3 years, 6 months ago (2017-06-02 18:20:01 UTC) #17
Guido Urdaneta
3 years, 6 months ago (2017-06-02 23:58:59 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2919973003/ by guidou@chromium.org.

The reason for reverting is: Does not properly fix the bug..

Powered by Google App Engine
This is Rietveld 408576698