Deleted redundant SymmetricKey::GetRawKey().

Deleted redundant SymmetricKey::GetRawKey().

This was functionally equivalent to SymmetricKey::key(), and also
returned a always true status code. Switching to key() allowed for
the simplification of downstream functions.

R=alemate@chromium.org, alokp@chromium.org, davidben@chromium.org, rogerta@chromium.org, stanisc@chromium.org

Review-Url: https://codereview.chromium.org/2934893003 .
Cr-Commit-Position: refs/heads/master@{#480868}
Committed: https://chromium.googlesource.com/chromium/src/+/7bdfcab4d07e8a0645078f638ce6adce46160d35

[cmumford, 2017-06-13 17:01:33]

The CQ bit was checked by cmumford@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:01:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 17:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 17:03:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cmumford, 2017-06-13 17:51:48]

The CQ bit was checked by cmumford@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 17:52:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cmumford, 2017-06-13 19:45:37]

cmumford@chromium.org changed reviewers:
+ alemate@chromium.org, davidben@chromium.org, lcwu@chromium.org,
rogerta@chromium.org, stanisc@chromium.org

[cmumford, 2017-06-13 19:45:38]

davidben@ for //crypto
icwu@ for //chromecast changes
alemate@ for chromeos changes
rogerta@ for signin changes
stanisc@ for //components

[commit-bot: I haz the power, 2017-06-13 19:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 19:57:38]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-06-13 20:00:00]

lgtm!

I suspect this is a remnant from NSS. The raw key probably wasn't as easily
accessible then?

[stanisc, 2017-06-13 20:23:10]

components/sync lgtm

[alokp, 2017-06-13 20:25:00]

alokp@chromium.org changed reviewers:
+ alokp@chromium.org

[alokp, 2017-06-13 20:25:01]

lgtm

[Roger Tawa OOO till Jul 10th, 2017-06-13 21:03:55]

local_auth.cc lgtm

[Alexander Alekseev, 2017-06-16 19:53:17]

lgtm

[cmumford, 2017-06-16 20:22:03]

The CQ bit was checked by cmumford@chromium.org

[cmumford, 2017-06-16 20:22:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
stanisc@chromium.org, rogerta@chromium.org, alemate@chromium.org,
davidben@chromium.org, alokp@chromium.org
Link to the patchset: https://codereview.chromium.org/2934893003/#ps20001
(title: "Rebased to fix conflict with ToT.")

[commit-bot: I haz the power, 2017-06-16 20:22:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 21:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 21:35:00]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cmumford, 2017-06-19 15:00:47]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2017-06-19 15:01:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 16:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 16:19:18]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[cmumford, 2017-06-20 17:15:56]

Description was changed from

==========
Deleted redundant SymmetricKey::GetRawKey().

This was functionally equivalent to SymmetricKey::key(), and also
returned a always true status code. Switching to key() allowed for
the simplification of downstream functions.
==========

to

==========
Deleted redundant SymmetricKey::GetRawKey().

This was functionally equivalent to SymmetricKey::key(), and also
returned a always true status code. Switching to key() allowed for
the simplification of downstream functions.

R=alemate@chromium.org, alokp@chromium.org, davidben@chromium.org,
rogerta@chromium.org, stanisc@chromium.org

Review-Url: https://codereview.chromium.org/2934893003 .
Cr-Commit-Position: refs/heads/master@{#480868}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bdfcab4d07e8a0645078f638ce6...
==========

[cmumford, 2017-06-20 17:15:58]

Committed patchset #2 (id:20001) manually as
7bdfcab4d07e8a0645078f638ce6adce46160d35 (presubmit successful).