chrome/browser/signin/local_auth.cc - Issue 2934893003: Deleted redundant SymmetricKey::GetRawKey().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/local_auth.cc

Issue 2934893003: Deleted redundant SymmetricKey::GetRawKey(). (Closed)

Patch Set: Rebased to fix conflict with ToT. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/local_auth.cc

diff --git a/chrome/browser/signin/local_auth.cc b/chrome/browser/signin/local_auth.cc

index 9cf1e08ccc6fed1e570bbc88adb81434ca7e8eb0..5ce69c4add696240b318f1596e29cba783294c31 100644

--- a/chrome/browser/signin/local_auth.cc

+++ b/chrome/browser/signin/local_auth.cc

@@ -108,9 +108,7 @@ std::string CreateSecurePasswordHash(const std::string& salt,

crypto::SymmetricKey::DeriveKeyFromPassword(

crypto::SymmetricKey::AES, password, salt, encoding.iteration_count,

encoding.hash_bits));

- std::string password_hash;

- const bool success = password_key->GetRawKey(&password_hash);

- DCHECK(success);

+ std::string password_hash = password_key->key();

DCHECK_EQ(encoding.hash_bytes, password_hash.length());

UMA_HISTOGRAM_TIMES("PasswordHash.CreateTime",