chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc - Issue 2934893003: Deleted redundant SymmetricKey::GetRawKey().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

Issue 2934893003: Deleted redundant SymmetricKey::GetRawKey(). (Closed)

Patch Set: Rebased to fix conflict with ToT. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc ('k') | chrome/browser/signin/local_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

index aa69f57a1fffe3a0322497b27b355bf7955ab46c..28446d16fdb19025675b3f9801e2efc79c3f3c8c 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

@@ -47,9 +47,8 @@ std::string BuildRawHMACKey() {

std::unique_ptr<crypto::SymmetricKey> key(

crypto::SymmetricKey::GenerateRandomKey(crypto::SymmetricKey::AES,

kHMACKeySizeInBits));

- std::string raw_result, result;

- key->GetRawKey(&raw_result);

- base::Base64Encode(raw_result, &result);

+ std::string result;

+ base::Base64Encode(key->key(), &result);

return result;

}