Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/sync/base/nigori_unittest.cc

Issue 2934893003: Deleted redundant SymmetricKey::GetRawKey(). (Closed)
Patch Set: Rebased to fix conflict with ToT. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/base/nigori.cc ('k') | crypto/hmac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/base/nigori_unittest.cc
diff --git a/components/sync/base/nigori_unittest.cc b/components/sync/base/nigori_unittest.cc
index 3dfdb6407d08fd306c396b11184e38b7a14b1cba..567237e279ef2123335fcc49214498d0a386d9d2 100644
--- a/components/sync/base/nigori_unittest.cc
+++ b/components/sync/base/nigori_unittest.cc
@@ -129,7 +129,7 @@ TEST(SyncNigoriTest, ExportImport) {
std::string user_key;
std::string encryption_key;
std::string mac_key;
- EXPECT_TRUE(nigori1.ExportKeys(&user_key, &encryption_key, &mac_key));
+ nigori1.ExportKeys(&user_key, &encryption_key, &mac_key);
Nigori nigori2;
EXPECT_TRUE(nigori2.InitByImport(user_key, encryption_key, mac_key));
@@ -159,7 +159,7 @@ TEST(SyncNigoriTest, InitByDerivationSetsUserKey) {
std::string user_key = "";
std::string encryption_key;
std::string mac_key;
- EXPECT_TRUE(nigori.ExportKeys(&user_key, &encryption_key, &mac_key));
+ nigori.ExportKeys(&user_key, &encryption_key, &mac_key);
EXPECT_NE(user_key, "");
}
@@ -171,7 +171,7 @@ TEST(SyncNigoriTest, ToleratesEmptyUserKey) {
std::string user_key;
std::string encryption_key;
std::string mac_key;
- EXPECT_TRUE(nigori1.ExportKeys(&user_key, &encryption_key, &mac_key));
+ nigori1.ExportKeys(&user_key, &encryption_key, &mac_key);
EXPECT_FALSE(user_key.empty());
EXPECT_FALSE(encryption_key.empty());
EXPECT_FALSE(mac_key.empty());
@@ -180,7 +180,7 @@ TEST(SyncNigoriTest, ToleratesEmptyUserKey) {
EXPECT_TRUE(nigori2.InitByImport("", encryption_key, mac_key));
user_key = "non-empty-value";
- EXPECT_TRUE(nigori2.ExportKeys(&user_key, &encryption_key, &mac_key));
+ nigori2.ExportKeys(&user_key, &encryption_key, &mac_key);
EXPECT_TRUE(user_key.empty());
EXPECT_FALSE(encryption_key.empty());
EXPECT_FALSE(mac_key.empty());
« no previous file with comments | « components/sync/base/nigori.cc ('k') | crypto/hmac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698