Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2934733002:
Workaround for Intel 6xxx clear to 0/1 bug (Closed)
|
Created:
3 years, 6 months ago by jiajia.qin Modified:
3 years, 5 months ago CC:
chromium-reviews, piman+watch_chromium.org, yunchao Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorkaround for Intel 6xxx clear to 0/1 bug
This is ported form skia fixing https://skia-review.googlesource.com/c/17327/
and https://skia-review.googlesource.com/c/16427/
BUG=710443
TEST=WebGL conformance test:framebuffer-texture-clear.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2934733002
Cr-Commit-Position: refs/heads/master@{#486150}
Committed: https://chromium.googlesource.com/chromium/src/+/01aa041da4c2327324ae3470c8e29f4829a9e928
Patch Set 1 #Patch Set 2 : Unify to use DoClearColor #Patch Set 3 : fix try-bot error #
Total comments: 4
Patch Set 4 : workaround at gl_gl_api_implementation.cc #
Total comments: 11
Patch Set 5 : rebase and move workarounds to gl_context #
Total comments: 8
Patch Set 6 : rebase and move GLWorkarounds to a member of GLContext #
Total comments: 2
Patch Set 7 : make gl_workarounds as a non-static member of GLContext #Patch Set 8 : fix try-bot error #
Total comments: 2
Patch Set 9 : Pass workarounds to gl_gl_api_implementation #Patch Set 10 : move gl_workarounds_ to a member of RealGLApi #
Total comments: 2
Patch Set 11 : rebased, put the definition of struct GLWorkarounds to a separate file #Patch Set 12 #
Total comments: 2
Patch Set 13 : rebased, rename setGLWorkarounds to set_gl_workarounds #
Messages
Total messages: 78 (55 generated)
Description was changed from ========== Workaround for Intel 6xxx clear to 0/1 bug This is ported form skia fixing https://skia-review.googlesource.com/c/17327/ and https://skia-review.googlesource.com/c/16427/ BUG=710443 TEST=WebGL conformance test:framebuffer-texture-clear.html ========== to ========== Workaround for Intel 6xxx clear to 0/1 bug This is ported form skia fixing https://skia-review.googlesource.com/c/17327/ and https://skia-review.googlesource.com/c/16427/ BUG=710443 TEST=WebGL conformance test:framebuffer-texture-clear.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jiajia.qin@intel.com changed reviewers: + zmo@chromium.org
Hi, Zhenyao. Please check if this patch is still needed since it's a little heavy that We need to workaround all glClearColor in commandbuffer. And this bug has been fixed in Mac10.12.5. During this, I found that gl_renderer is not supported in gpu driver bug workaround on MacOS due to crbug.com/222934. But according to bug's description, it seems that it only happens on NVIDIA gpu. So I changed it to skip NVDIA gpuinfo collection. So I can use gl_renderer in gpu_driver_bug_list.json. If you think this part is useful, I can spit it out and send to review. Thanks.
This is similar to https://codereview.chromium.org/2827573007/ You definitely miss some glClear calls, for example, gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc Also, there is no mechanism to force future code to always call DoClear instead of glClear, so this is bug prone. I think the workaround should be wired up to ui/gl/gl_gl_api_implementation.cc instead. https://codereview.chromium.org/2934733002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2934733002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2540: "gl_renderer": "Intel\\(R\\) (HD|Iris\\(TM\\)) Graphics 6.*", That's not good to use gl_renderer on Mac because it's not available until very late. Let's list all affected device IDs on MacOSX. There should be only a few. https://codereview.chromium.org/2934733002/diff/40001/services/ui/gpu/gpu_ser... File services/ui/gpu/gpu_service.cc (right): https://codereview.chromium.org/2934733002/diff/40001/services/ui/gpu/gpu_ser... services/ui/gpu/gpu_service.cc:287: if (gpu_info_.gpu.vendor_id == 0x10de) { // NVIDIA See my comment in the workaround file. Let's not make changes in this file.
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
>I think the workaround should be wired up to ui/gl/gl_gl_api_implementation.cc instead. Hi, Zhenyao. Thanks for your advice. I have moved the workaround to gl_gl_api_implementation.cc. Please take another look. https://codereview.chromium.org/2934733002/diff/40001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2934733002/diff/40001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2540: "gl_renderer": "Intel\\(R\\) (HD|Iris\\(TM\\)) Graphics 6.*", On 2017/06/13 19:01:24, Zhenyao Mo wrote: > That's not good to use gl_renderer on Mac because it's not available until very > late. Let's list all affected device IDs on MacOSX. There should be only a few. Done. https://codereview.chromium.org/2934733002/diff/40001/services/ui/gpu/gpu_ser... File services/ui/gpu/gpu_service.cc (right): https://codereview.chromium.org/2934733002/diff/40001/services/ui/gpu/gpu_ser... services/ui/gpu/gpu_service.cc:287: if (gpu_info_.gpu.vendor_id == 0x10de) { // NVIDIA On 2017/06/13 19:01:24, Zhenyao Mo wrote: > See my comment in the workaround file. Let's not make changes in this file. Acknowledged.
https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2513: "id": 231, Don't do that even if we skip one ID. That will mess up histograms etc. There might be a deleted entry. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2529: "id": 232, Same here. Don't change it. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2541: "id": 233, 234 or whatever the latest + 1 https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2548: "value": "10.12.4" Are you sure it's fixed in 10.12.5? If not, that's not add a version qualifier. Wait until a fix is released and then update this entry. https://codereview.chromium.org/2934733002/diff/60001/ui/gl/gl_driver_workaro... File ui/gl/gl_driver_workarounds.h (right): https://codereview.chromium.org/2934733002/diff/60001/ui/gl/gl_driver_workaro... ui/gl/gl_driver_workarounds.h:15: GL_EXPORT extern bool clearToBoundaryValuesIsBroken; wrong naming convention https://codereview.chromium.org/2934733002/diff/60001/ui/gl/gl_driver_workaro... ui/gl/gl_driver_workarounds.h:15: GL_EXPORT extern bool clearToBoundaryValuesIsBroken; I really think we should avoid global variables. I suggest you make this a struct and make it part of either gl_context or gl_share_group.
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Zhenyao, please take another look. Thanks. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2513: "id": 231, On 2017/06/19 21:47:20, Zhenyao Mo wrote: > Don't do that even if we skip one ID. That will mess up histograms etc. There > might be a deleted entry. Acknowledged. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2529: "id": 232, On 2017/06/19 21:47:20, Zhenyao Mo wrote: > Same here. Don't change it. Acknowledged. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2541: "id": 233, On 2017/06/19 21:47:20, Zhenyao Mo wrote: > 234 or whatever the latest + 1 Acknowledged. https://codereview.chromium.org/2934733002/diff/60001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list.json:2548: "value": "10.12.4" On 2017/06/19 21:47:20, Zhenyao Mo wrote: > Are you sure it's fixed in 10.12.5? If not, that's not add a version qualifier. > Wait until a fix is released and then update this entry. I verified that it has been fixed in 10.12.6. https://codereview.chromium.org/2934733002/diff/60001/ui/gl/gl_driver_workaro... File ui/gl/gl_driver_workarounds.h (right): https://codereview.chromium.org/2934733002/diff/60001/ui/gl/gl_driver_workaro... ui/gl/gl_driver_workarounds.h:15: GL_EXPORT extern bool clearToBoundaryValuesIsBroken; On 2017/06/19 21:47:20, Zhenyao Mo wrote: > I really think we should avoid global variables. > > I suggest you make this a struct and make it part of either gl_context or > gl_share_group. Done.
Sorry for not being clear. https://codereview.chromium.org/2934733002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/2934733002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/feature_info.cc:562: gl::GLWorkarounds glWorkarounds; gl_workarounds https://codereview.chromium.org/2934733002/diff/80001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_workaround_type.h (right): https://codereview.chromium.org/2934733002/diff/80001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_workaround_type.h:33: clear_to_boundary_values_is_broken) \ clear_to_zero_or_one_broken https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.cc File ui/gl/gl_context.cc (right): https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.cc#new... ui/gl/gl_context.cc:35: GLWorkarounds gl_workarounds; Sorry. What I mean is the gl_workarounds should be a member of the GLContext class. https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.h#newc... ui/gl/gl_context.h:74: bool clearToBoundaryValuesIsBroken = false; clear_to_boundary_values_broken
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, Zhenyao. Please check if this cl is clear now. Sorry for the misunderstanding earlier. https://codereview.chromium.org/2934733002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/feature_info.cc (right): https://codereview.chromium.org/2934733002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/feature_info.cc:562: gl::GLWorkarounds glWorkarounds; On 2017/06/20 21:34:17, Zhenyao Mo wrote: > gl_workarounds Done. https://codereview.chromium.org/2934733002/diff/80001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_workaround_type.h (right): https://codereview.chromium.org/2934733002/diff/80001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_workaround_type.h:33: clear_to_boundary_values_is_broken) \ On 2017/06/20 21:34:17, Zhenyao Mo wrote: > clear_to_zero_or_one_broken Done. https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.cc File ui/gl/gl_context.cc (right): https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.cc#new... ui/gl/gl_context.cc:35: GLWorkarounds gl_workarounds; On 2017/06/20 21:34:17, Zhenyao Mo wrote: > Sorry. What I mean is the gl_workarounds should be a member of the GLContext > class. Done. https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/2934733002/diff/80001/ui/gl/gl_context.h#newc... ui/gl/gl_context.h:74: bool clearToBoundaryValuesIsBroken = false; On 2017/06/20 21:34:17, Zhenyao Mo wrote: > clear_to_boundary_values_broken Done.
https://codereview.chromium.org/2934733002/diff/100001/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/2934733002/diff/100001/ui/gl/gl_context.h#new... ui/gl/gl_context.h:236: static GLWorkarounds gl_workarounds_; Again, sorry for not being clear. I think this needs to be a non-static member. Thinking about dual GPU situation, this really should be per context setting, not a global setting.
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2934733002/diff/100001/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/2934733002/diff/100001/ui/gl/gl_context.h#new... ui/gl/gl_context.h:236: static GLWorkarounds gl_workarounds_; On 2017/06/21 16:52:05, Zhenyao Mo wrote: > Again, sorry for not being clear. I think this needs to be a non-static member. > Thinking about dual GPU situation, this really should be per context setting, > not a global setting. OK. I have modified it to a non-static member. But a problem is that I need to get the right context object in gl_gl_api_implementation.cc. Currently I added a gl_context_ in RealGLApi like version_ did. Please check if it's the best method to do it.
https://codereview.chromium.org/2934733002/diff/140001/ui/gl/gl_context.cc File ui/gl/gl_context.cc (right): https://codereview.chromium.org/2934733002/diff/140001/ui/gl/gl_context.cc#ne... ui/gl/gl_context.cc:254: real_gl_api_->setGLContext(this); This is less optimal. GLContext owns real_gl_api_, so you can easily pass GLWorkaround to real_gl_api_ without creating this back link. For example, in SetGLWorkarounds, you can just pass it to real_gl_api_. If real_gl_api_ is null at the time (please double check the life cycle and order of things), then you can do it in GLContext::CreateGLApi()
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2934733002/diff/140001/ui/gl/gl_context.cc File ui/gl/gl_context.cc (right): https://codereview.chromium.org/2934733002/diff/140001/ui/gl/gl_context.cc#ne... ui/gl/gl_context.cc:254: real_gl_api_->setGLContext(this); On 2017/06/26 21:45:22, Zhenyao Mo wrote: > This is less optimal. GLContext owns real_gl_api_, so you can easily pass > GLWorkaround to real_gl_api_ without creating this back link. > > For example, in SetGLWorkarounds, you can just pass it to real_gl_api_. If > real_gl_api_ is null at the time (please double check the life cycle and order > of things), then you can do it in GLContext::CreateGLApi() Sorry for so many iterations. Please check the newest patch which will pass the GLWorkarounds to RealGLApi. Beside that, patch set 9 is also a workable method. Both are per-context and set GLWorkarounds by GLContext. The main differ is one has GLWorkaround as a member of RealGLApi, another has GLWorkaround outside of RealGLApi but in gl_gl_api_implementation.cc. If you think patch set 9 is more simple, I can re-back to it. Thanks.
CC Yunchao@
Ping Zhenyao@. Please take a look when you have time. Thanks.
Sorry for the delay - I was on vacation. Mostly look good with one minor suggestion. https://codereview.chromium.org/2934733002/diff/180001/ui/gl/gl_gl_api_implem... File ui/gl/gl_gl_api_implementation.h (right): https://codereview.chromium.org/2934733002/diff/180001/ui/gl/gl_gl_api_implem... ui/gl/gl_gl_api_implementation.h:130: GLWorkarounds* gl_workarounds_; Let's make it GLWorkarounds gl_workarounds_ instead. Copying is trivia, and we don't have to worry about lifetime.
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jiajia.qin@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi Mo, thanks for your patient review. Please take a final look. https://codereview.chromium.org/2934733002/diff/180001/ui/gl/gl_gl_api_implem... File ui/gl/gl_gl_api_implementation.h (right): https://codereview.chromium.org/2934733002/diff/180001/ui/gl/gl_gl_api_implem... ui/gl/gl_gl_api_implementation.h:130: GLWorkarounds* gl_workarounds_; On 2017/07/11 18:24:48, Zhenyao Mo wrote: > Let's make it GLWorkarounds gl_workarounds_ instead. Copying is trivia, and we > don't have to worry about lifetime. Ack. To make it GLWorkarounds gl_workarounds_ instead of GLWorkaronds*, I have to put the definition of struct of GLWorkarounds in a separate file because that the original definition of GLworkarounds is in gl_context.h and gl_context.h includes gl_gl_api_implementation.h.
Please fix the function naming before landing LGTM after the fix https://codereview.chromium.org/2934733002/diff/220001/ui/gl/gl_gl_api_implem... File ui/gl/gl_gl_api_implementation.h (right): https://codereview.chromium.org/2934733002/diff/220001/ui/gl/gl_gl_api_implem... ui/gl/gl_gl_api_implementation.h:121: void setGLWorkarounds(const GLWorkarounds& workarounds); You need to either name it SetGLWorkarounds() or set_gl_workarounds()
>Please fix the function naming before landing Done. Will commit. https://codereview.chromium.org/2934733002/diff/220001/ui/gl/gl_gl_api_implem... File ui/gl/gl_gl_api_implementation.h (right): https://codereview.chromium.org/2934733002/diff/220001/ui/gl/gl_gl_api_implem... ui/gl/gl_gl_api_implementation.h:121: void setGLWorkarounds(const GLWorkarounds& workarounds); On 2017/07/12 17:00:15, Zhenyao Mo wrote: > You need to either name it SetGLWorkarounds() or set_gl_workarounds() Done. Rename to set_gl_workarounds()
The CQ bit was checked by jiajia.qin@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2934733002/#ps240001 (title: "rebased, rename setGLWorkarounds to set_gl_workarounds")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
jiajia.qin@intel.com changed reviewers: + piman@chromium.org
Seems that missing LGTM for ui/gl. piman@, can you look at for that part?
lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 240001, "attempt_start_ts": 1499902226620800,
"parent_rev": "c5f3486d95e4ab8fb29632d3d3cf7dc90784dab1", "commit_rev":
"01aa041da4c2327324ae3470c8e29f4829a9e928"}
Message was sent while issue was closed.
Description was changed from ========== Workaround for Intel 6xxx clear to 0/1 bug This is ported form skia fixing https://skia-review.googlesource.com/c/17327/ and https://skia-review.googlesource.com/c/16427/ BUG=710443 TEST=WebGL conformance test:framebuffer-texture-clear.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Workaround for Intel 6xxx clear to 0/1 bug This is ported form skia fixing https://skia-review.googlesource.com/c/17327/ and https://skia-review.googlesource.com/c/16427/ BUG=710443 TEST=WebGL conformance test:framebuffer-texture-clear.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2934733002 Cr-Commit-Position: refs/heads/master@{#486150} Committed: https://chromium.googlesource.com/chromium/src/+/01aa041da4c2327324ae3470c8e2... ==========
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as https://chromium.googlesource.com/chromium/src/+/01aa041da4c2327324ae3470c8e2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
