ui/gl/gl_driver_workarounds.h - Issue 2934733002: Workaround for Intel 6xxx clear to 0/1 bug

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/gl_driver_workarounds.h

Issue 2934733002: Workaround for Intel 6xxx clear to 0/1 bug (Closed)

Patch Set: workaround at gl_gl_api_implementation.cc Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GL_GL_DRIVER_WORKAROUNDS_H_

	6 #define UI_GL_GL_DRIVER_WORKAROUNDS_H_

	7

	8 #include "ui/gl/gl_export.h"

	9

	10 namespace gl {

	11 namespace workarounds {

	12

	13 // glClearColor does not always work on Intel 6xxx Mac drivers. See

	14 // crbug.com/710443.

	15 GL_EXPORT extern bool clearToBoundaryValuesIsBroken;
	Zhenyao Mo 2017/06/19 21:47:20 wrong naming convention wrong naming convention Zhenyao Mo 2017/06/19 21:47:20 I really think we should avoid global variables. I really think we should avoid global variables. I suggest you make this a struct and make it part of either gl_context or gl_share_group. jiajia.qin 2017/06/20 04:22:45 Done. Show quoted text On 2017/06/19 21:47:20, Zhenyao Mo wrote: > I really think we should avoid global variables. > > I suggest you make this a struct and make it part of either gl_context or > gl_share_group. Done.
	16

	17 } // namespace workarounds

	18 } // namespace gl

	19

	20 #endif // UI_GL_GL_DRIVER_WORKAROUNDS_H_

OLD	NEW