Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/b1f129d258b550da6cff3e4d3c8262d6d8d77851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -102 lines) Patch
M pkg/compiler/lib/src/elements/entities.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 6 chunks +135 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-09 16:22:06 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-09 19:47:11 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-12 07:42:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1f129d258b550da6cff3e4d3c8262d6d8d77851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698