pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart - Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

index 49d3a27c8fcaf434c2e2e9869732f895fe5890b5..fbcfd6ff756310071c26e2def0680180d40ff7c3 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

@@ -163,13 +163,13 @@ class ContainerBuilder extends CodeEmitterHelper {

}

});

}

- Name memberName = new Name(member.name, member.library);

+ Name memberName = member.memberName;

if (canBeReflected) {

jsAst.LiteralString reflectionName;

if (member.isConstructor) {

// TODO(herhut): This registers name as a mangled name. Do we need this

// given that we use a different name below?

- emitter.getReflectionName(member, name);

+ emitter.getReflectionMemberName(member, name);

reflectionName = new jsAst.LiteralString(

'"new ${utils.reconstructConstructorName(member)}"');

} else {