pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart - Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

index 70d80e07f6df5148abb78ba6bb1bc452b54f6f37..dbd06fd251d3ab8b530c2b94b3c91f23b6747ce8 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart

@@ -51,7 +51,8 @@ class NsmEmitter extends CodeEmitterHelper {

List<jsAst.Name> names = addedJsNames.keys.toList()..sort();

for (jsAst.Name jsName in names) {

Selector selector = addedJsNames[jsName];

- String reflectionName = emitter.getReflectionName(selector, jsName);

+ String reflectionName =

+ emitter.getReflectionSelectorName(selector, jsName);

if (reflectionName != null) {

emitter.mangledFieldNames[jsName] = reflectionName;