Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index b85aac59fe6d9446fdffd6cd72a8783fb15cbc11..528d4e2aa4db7245d8edc08b757668518afbf1da 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -948,7 +948,7 @@ class Namer {
// No superclass uses the disambiguated name as a property name, so we can
// use it for this field. This generates nicer field names since otherwise
// the field name would have to be mangled.
- return _disambiguateMember(element.memberName);
+ return _disambiguateMember(new Name(element.name, element.library));
}
bool _isShadowingSuperField(Element element) {
@@ -987,8 +987,7 @@ class Namer {
jsAst.Name getterForElement(MemberEntity element) {
// We dynamically create getters from the field-name. The getter name must
// therefore be derived from the instance field-name.
- jsAst.Name name = _disambiguateMember(
- new Name(element.name, element.library, isSetter: element.isSetter));
+ jsAst.Name name = _disambiguateMember(element.memberName);
return deriveGetterName(name);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/mirrors_analysis.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698