Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 2933553002: Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
index ab8b705f4a48f55f4e507f932c6744f2b554a106..1d359fa6e26e30929c25db6b90a5a4ed888fff95 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
@@ -12,7 +12,6 @@ import '../../deferred_load.dart' show OutputUnit;
import '../../elements/elements.dart'
show ClassElement, FieldElement, MemberElement;
import '../../elements/entities.dart';
-import '../../elements/names.dart';
import '../../js/js.dart' as jsAst;
import '../../js/js.dart' show js;
import '../../js_backend/js_backend.dart' show CompoundName, Namer;
@@ -365,7 +364,8 @@ class ClassEmitter extends CodeEmitterHelper {
.registerElementAst(classBuilder.element, propertyValue);
enclosingBuilder.addProperty(className, propertyValue);
- String reflectionName = emitter.getReflectionName(classEntity, className);
+ String reflectionName =
+ emitter.getReflectionClassName(classEntity, className);
if (reflectionName != null) {
// TODO(johnniwinther): Handle class entities.
ClassElement classElement = classEntity;
@@ -447,10 +447,9 @@ class ClassEmitter extends CodeEmitterHelper {
MemberElement member, jsAst.Name name, ClassBuilder builder,
{bool isGetter}) {
Selector selector = isGetter
- ? new Selector.getter(new Name(member.name, member.library))
- : new Selector.setter(
- new Name(member.name, member.library, isSetter: true));
- String reflectionName = emitter.getReflectionName(selector, name);
+ ? new Selector.getter(member.memberName.getter)
+ : new Selector.setter(member.memberName.setter);
+ String reflectionName = emitter.getReflectionSelectorName(selector, name);
if (reflectionName != null) {
var reflectable = js(
backend.mirrorsData.isMemberAccessibleByReflection(member)
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698