Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2932593003: DevTools: migrate ComputedStyleWidget to shadow (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate ComputedStyleWidget to shadow The computedStylesSidebarPane.css was injected in both the widget's element and its treeOutline. Now, there are two css files, one for each. BUG=726972 Review-Url: https://codereview.chromium.org/2932593003 Cr-Commit-Position: refs/heads/master@{#478160} Committed: https://chromium.googlesource.com/chromium/src/+/0254120193fa62034e87adab6d4484336e7c86aa

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : ac #

Messages

Total messages: 13 (8 generated)
luoe
Please take a look
3 years, 6 months ago (2017-06-08 23:09:07 UTC) #5
lushnikov
lgtm https://codereview.chromium.org/2932593003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2932593003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode130 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:130: * @param {string=} activeClassName should not be optional ...
3 years, 6 months ago (2017-06-08 23:23:40 UTC) #6
luoe
https://codereview.chromium.org/2932593003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2932593003/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode130 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:130: * @param {string=} activeClassName On 2017/06/08 23:23:40, lushnikov wrote: ...
3 years, 6 months ago (2017-06-08 23:26:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2932593003/40001
3 years, 6 months ago (2017-06-08 23:27:14 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 01:57:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0254120193fa62034e87adab6d44...

Powered by Google App Engine
This is Rietveld 408576698