Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2927573004: DevTools: migrate StylesSidebarPane to shadow (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
alph, einbinder, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate StylesSidebarPane to shadow BUG=726972 Review-Url: https://codereview.chromium.org/2927573004 Cr-Commit-Position: refs/heads/master@{#478531} Committed: https://chromium.googlesource.com/chromium/src/+/75770b99c7a2a5a2a426881e5a766e4fcbb4648a

Patch Set 1 #

Patch Set 2 : rebase over ComputedWidget migration #

Patch Set 3 : rebase ac #

Patch Set 4 : with similarity 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -379 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-2/filter-matched-styles-hides-separators.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/style-update-during-selector-edit.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 6 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 5 chunks +0 lines, -198 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/elements/stylesSidebarPane.css View 1 2 3 6 chunks +6 lines, -165 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
luoe
Please take a look
3 years, 6 months ago (2017-06-07 22:27:23 UTC) #2
luoe
On 2017/06/07 22:27:23, luoe wrote: > Please take a look Actually, this isn't ready yet. ...
3 years, 6 months ago (2017-06-08 01:05:18 UTC) #3
luoe
Ready for review! The "Filter" toolbar is used in SSP and ComputedStylesWidget, but is very ...
3 years, 6 months ago (2017-06-08 23:10:14 UTC) #5
einbinder
lgtm
3 years, 6 months ago (2017-06-09 00:19:36 UTC) #6
dgozman
alph, mind taking a look please?
3 years, 6 months ago (2017-06-09 22:25:39 UTC) #8
alph
Could you please reupload the patch with --similarity=10
3 years, 6 months ago (2017-06-09 23:30:49 UTC) #9
luoe
On 2017/06/09 23:30:49, alph wrote: > Could you please reupload the patch with --similarity=10 Absolutely! ...
3 years, 6 months ago (2017-06-10 00:54:24 UTC) #10
alph
lgtm
3 years, 6 months ago (2017-06-10 04:23:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927573004/80001
3 years, 6 months ago (2017-06-11 06:16:59 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-11 08:03:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/75770b99c7a2a5a2a426881e5a76...

Powered by Google App Engine
This is Rietveld 408576698