Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js

Issue 2932593003: DevTools: migrate ComputedStyleWidget to shadow (Closed)
Patch Set: ac Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
index 40056c8ad0d30bf30ad93f2064abb4ba0aadf975..9bde158e06764320e90be6dcfc45ef9e74bf77e5 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
@@ -32,9 +32,7 @@
*/
Elements.ComputedStyleWidget = class extends UI.ThrottledWidget {
constructor() {
- super();
- this.element.classList.add('computed-style-sidebar-pane');
-
+ super(true);
this.registerRequiredCSS('elements/computedStyleSidebarPane.css');
this._alwaysShowComputedProperties = {'display': true, 'height': true, 'width': true};
@@ -47,10 +45,10 @@ Elements.ComputedStyleWidget = class extends UI.ThrottledWidget {
this._showInheritedComputedStylePropertiesSetting.addChangeListener(
this._showInheritedComputedStyleChanged.bind(this));
- var hbox = this.element.createChild('div', 'hbox styles-sidebar-pane-toolbar');
+ var hbox = this.contentElement.createChild('div', 'hbox styles-sidebar-pane-toolbar');
var filterContainerElement = hbox.createChild('div', 'styles-sidebar-pane-filter-box');
var filterInput = Elements.StylesSidebarPane.createPropertyFilterElement(
- Common.UIString('Filter'), hbox, filterCallback.bind(this));
+ Common.UIString('Filter'), hbox, filterCallback.bind(this), 'styles-filter-engaged');
UI.ARIAUtils.setAccessibleName(filterInput, Common.UIString('Filter Computed Styles'));
filterContainerElement.appendChild(filterInput);
@@ -60,9 +58,9 @@ Elements.ComputedStyleWidget = class extends UI.ThrottledWidget {
this._propertiesOutline = new UI.TreeOutlineInShadow();
this._propertiesOutline.hideOverflow();
- this._propertiesOutline.registerRequiredCSS('elements/computedStyleSidebarPane.css');
+ this._propertiesOutline.registerRequiredCSS('elements/computedStyleWidgetTree.css');
this._propertiesOutline.element.classList.add('monospace', 'computed-properties');
- this.element.appendChild(this._propertiesOutline.element);
+ this.contentElement.appendChild(this._propertiesOutline.element);
this._linkifier = new Components.Linkifier(Elements.ComputedStyleWidget._maxLinkLength);
@@ -76,7 +74,7 @@ Elements.ComputedStyleWidget = class extends UI.ThrottledWidget {
}
var fontsWidget = new Elements.PlatformFontsWidget(this._computedStyleModel);
- fontsWidget.show(this.element);
+ fontsWidget.show(this.contentElement);
}
_showInheritedComputedStyleChanged() {

Powered by Google App Engine
This is Rietveld 408576698