Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2524913002: DevTools: expect length/size hints in descriptions with parenthesis (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: expect length/size hints in descriptions with parenthesis This CL let's DevTools properly handle array lengths following a change to the way descriptions are generated in injected-script-source, "Array(10)" instead of "Array[10]". Related CL in V8: https://codereview.chromium.org/2521853003 BUG=405845 Committed: https://crrev.com/4db8d87410e8661671fc8e9f82d8dd2c9b4f5153 Cr-Commit-Position: refs/heads/master@{#434282}

Patch Set 1 #

Messages

Total messages: 17 (11 generated)
luoe
This change is also described in section B3 on array hints in the doc linked ...
4 years, 1 month ago (2016-11-22 23:53:29 UTC) #4
dgozman
lgtm
4 years, 1 month ago (2016-11-23 01:41:44 UTC) #5
kozy
lgtm
4 years, 1 month ago (2016-11-23 02:45:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524913002/1
4 years ago (2016-11-23 22:06:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 23:47:09 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-23 23:49:47 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db8d87410e8661671fc8e9f82d8dd2c9b4f5153
Cr-Commit-Position: refs/heads/master@{#434282}

Powered by Google App Engine
This is Rietveld 408576698