Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2931673003: config_service: fetch repos and metadata concurrently (Closed)

Created:
3 years, 6 months ago by nodir
Modified:
3 years, 6 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Vadim Sh.
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: fetch repos and metadata concurrently optimize get_projects() by calling get_repos_async and get_metadata_async concurrently R=hinoka@chromium.org, sergeyberezin@chromium.org BUG=730832 Review-Url: https://codereview.chromium.org/2931673003 Committed: https://github.com/luci/luci-py/commit/a24b2b14dc50bd7b711f2ca93ffb481becb15e89

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : use ctx.memcache_[gs]et #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -54 lines) Patch
M appengine/config_service/acl.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M appengine/config_service/acl_test.py View 1 2 chunks +4 lines, -6 lines 0 comments Download
M appengine/config_service/api.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M appengine/config_service/api_test.py View 1 4 chunks +12 lines, -14 lines 0 comments Download
M appengine/config_service/projects.py View 1 2 4 chunks +48 lines, -29 lines 0 comments Download
M appengine/config_service/projects_test.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
nodir
PTAL
3 years, 6 months ago (2017-06-08 05:20:15 UTC) #1
nodir
changed reviewers
3 years, 6 months ago (2017-06-08 06:36:15 UTC) #3
nodir
PTAL
3 years, 6 months ago (2017-06-09 17:07:33 UTC) #5
Ryan Tseng
lgtm
3 years, 6 months ago (2017-06-09 17:50:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931673003/1
3 years, 6 months ago (2017-06-09 18:02:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/36a6d8cdf90b2410)
3 years, 6 months ago (2017-06-09 18:05:41 UTC) #11
Sergey Berezin (google)
lgtm
3 years, 6 months ago (2017-06-12 18:42:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931673003/40001
3 years, 6 months ago (2017-06-12 20:50:40 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 20:53:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/a24b2b14dc50bd7b711f2ca93ffb481becb15e89

Powered by Google App Engine
This is Rietveld 408576698