Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: appengine/config_service/acl.py

Issue 2931673003: config_service: fetch repos and metadata concurrently (Closed)
Patch Set: use ctx.memcache_[gs]et Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/config_service/acl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/config_service/acl.py
diff --git a/appengine/config_service/acl.py b/appengine/config_service/acl.py
index 63d3b2e60477991658a67595d996caba9de930d1..b9b74797e27920d699c8b9f1631ddd5360c3923a 100644
--- a/appengine/config_service/acl.py
+++ b/appengine/config_service/acl.py
@@ -99,7 +99,8 @@ def has_projects_access(project_ids):
super_group = get_acl_cfg().project_access_group
if is_admin() or super_group and auth.is_group_member(super_group):
return {pid: True for pid in project_ids}
+ metadata = projects.get_metadata_async(project_ids).get_result()
return {
pid: meta and config.api._has_access(meta.access)
- for pid, meta in projects.get_metadata(project_ids).iteritems()
+ for pid, meta in metadata.iteritems()
}
« no previous file with comments | « no previous file | appengine/config_service/acl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698