config_service: fetch repos and metadata concurrently

appengine/config_service/acl_test.py

 #!/usr/bin/env python
 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from test_env import future
 import test_env
 test_env.setup_test_env()
 
 from test_support import test_case
@@ skipping 46 matching lines @@
           id='swarming', access=['group:swarming-app']),
     ])
     auth.is_group_member.side_effect = lambda g, *_: g == 'swarming-app'
 
     self.assertTrue(can_read_config_set('services/swarming'))
 
   def test_has_service_access_no_access(self):
     self.assertFalse(can_read_config_set('services/swarming'))
 
   def test_has_project_access_group(self):
-    self.mock(projects, 'get_metadata', mock.Mock())
-    projects.get_metadata.return_value = {
+    self.mock(projects, 'get_metadata_async', mock.Mock(return_value=future({
       'secret': project_config_pb2.ProjectCfg(
           access=['group:googlers', 'a@a.com']),
-    }
+    })))
 
     self.assertFalse(can_read_config_set('projects/secret'))
 
     auth.is_group_member.side_effect = lambda name, *_: name == 'googlers'
     self.assertTrue(can_read_config_set('projects/secret'))
 
     auth.is_group_member.side_effect = lambda name, *_: name == 'project-admins'
     self.assertTrue(can_read_config_set('projects/secret'))
 
   def test_has_project_access_identity(self):
-    self.mock(projects, 'get_metadata', mock.Mock())
-    projects.get_metadata.return_value = {
+    self.mock(projects, 'get_metadata_async', mock.Mock(return_value=future({
       'secret': project_config_pb2.ProjectCfg(
           access=['group:googlers', 'a@a.com']),
-    }
+    })))
 
     self.assertFalse(can_read_config_set('projects/secret'))
 
     auth.get_current_identity.return_value = auth.Identity('user', 'a@a.com')
     self.assertTrue(can_read_config_set('projects/secret'))
 
   def test_can_read_project_config_no_access(self):
     self.assertFalse(has_project_access('projects/swarming'))
     self.assertFalse(can_read_config_set('projects/swarming/refs/heads/x'))
 
   def test_malformed_config_set(self):
     with self.assertRaises(ValueError):
       can_read_config_set('invalid config set')
 
 
 if __name__ == '__main__':
   test_env.main()