Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: appengine/config_service/acl_test.py

Issue 2931673003: config_service: fetch repos and metadata concurrently (Closed)
Patch Set: use ctx.memcache_[gs]et Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/config_service/acl.py ('k') | appengine/config_service/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/config_service/acl_test.py
diff --git a/appengine/config_service/acl_test.py b/appengine/config_service/acl_test.py
index e7b38bac07c92eca5d14fba6276c83cb7275c7f8..7981f92c4c5eba508f4acd810f89f5f5b7bf7742 100755
--- a/appengine/config_service/acl_test.py
+++ b/appengine/config_service/acl_test.py
@@ -64,11 +64,10 @@ class AclTestCase(test_case.TestCase):
self.assertFalse(can_read_config_set('services/swarming'))
def test_has_project_access_group(self):
- self.mock(projects, 'get_metadata', mock.Mock())
- projects.get_metadata.return_value = {
+ self.mock(projects, 'get_metadata_async', mock.Mock(return_value=future({
'secret': project_config_pb2.ProjectCfg(
access=['group:googlers', 'a@a.com']),
- }
+ })))
self.assertFalse(can_read_config_set('projects/secret'))
@@ -79,11 +78,10 @@ class AclTestCase(test_case.TestCase):
self.assertTrue(can_read_config_set('projects/secret'))
def test_has_project_access_identity(self):
- self.mock(projects, 'get_metadata', mock.Mock())
- projects.get_metadata.return_value = {
+ self.mock(projects, 'get_metadata_async', mock.Mock(return_value=future({
'secret': project_config_pb2.ProjectCfg(
access=['group:googlers', 'a@a.com']),
- }
+ })))
self.assertFalse(can_read_config_set('projects/secret'))
« no previous file with comments | « appengine/config_service/acl.py ('k') | appengine/config_service/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698