Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2931033003: Rename ServiceWorkerContextObserver to ServiceWorkerContextCoreObserver. (Closed)

Created:
3 years, 6 months ago by dominickn
Modified:
3 years, 6 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, awdf+watch_chromium.org, shimazu+serviceworker_chromium.org, iclelland+watch_chromium.org, mlamouri+watch-notifications_chromium.org, serviceworker-reviews, jam, chasej+watch_chromium.org, nhiroki, Peter Beverloo, kinuko+serviceworker, blink-worker-reviews_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, johnme+watch_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ServiceWorkerContextObserver to ServiceWorkerContextCoreObserver. The existing observer is within content's implementation boundary, and actually observes a ServiceWorkerContextCore or a ServiceWorkerContextWrapper. Future CLs will make the observer only observe a ServiceWorkerContextCore to reflect its new name. This CL purely renames the ServiceWorkerContextObserver. This prepares for a ServiceWorkerContextObserver in content's public API (mirroring the public ServiceWorkerContext class). This new observer will allow classes in //chrome to observe events such as successful service worker registrations. BUG=625051 Review-Url: https://codereview.chromium.org/2931033003 Cr-Commit-Position: refs/heads/master@{#478885} Committed: https://chromium.googlesource.com/chromium/src/+/eadb0e90a6c4bc0e33c4436f8941b9534237b282

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -182 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browsing_data/clear_site_data_throttle_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/platform_notification_context_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/notifications/platform_notification_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/push_messaging/push_messaging_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 13 chunks +29 lines, -27 lines 0 comments Download
A + content/browser/service_worker/service_worker_context_core_observer.h View 3 chunks +5 lines, -5 lines 0 comments Download
D content/browser/service_worker/service_worker_context_observer.h View 1 chunk +0 lines, -101 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_watcher.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_watcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (18 generated)
dominickn
PTAL, thanks!
3 years, 6 months ago (2017-06-09 06:03:01 UTC) #10
kinuko
lgtm
3 years, 6 months ago (2017-06-09 08:27:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931033003/60001
3 years, 6 months ago (2017-06-12 23:56:35 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 03:23:54 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/eadb0e90a6c4bc0e33c4436f8941...

Powered by Google App Engine
This is Rietveld 408576698