content/browser/service_worker/service_worker_browsertest.cc - Issue 2931033003: Rename ServiceWorkerContextObserver to ServiceWorkerContextCoreObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2931033003: Rename ServiceWorkerContextObserver to ServiceWorkerContextCoreObserver. (Closed)

Patch Set: Typo Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/push_messaging/push_messaging_context.h ('k') | content/browser/service_worker/service_worker_context_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index c3c95bb399e1412b49f74cdff2059b7b4e43e2de..235cf5219ee9108aef9e971326e271da5675995b 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -36,7 +36,7 @@

#include "content/browser/service_worker/embedded_worker_registry.h"

#include "content/browser/service_worker/embedded_worker_status.h"

#include "content/browser/service_worker/service_worker_context_core.h"

-#include "content/browser/service_worker/service_worker_context_observer.h"

+#include "content/browser/service_worker/service_worker_context_core_observer.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

#include "content/browser/service_worker/service_worker_fetch_dispatcher.h"

#include "content/browser/service_worker/service_worker_registration.h"

@@ -174,7 +174,7 @@ void ExpectResultAndRun(bool expected,

}

class WorkerActivatedObserver

- : public ServiceWorkerContextObserver,

+ : public ServiceWorkerContextCoreObserver,

public base::RefCountedThreadSafe<WorkerActivatedObserver> {

public:

explicit WorkerActivatedObserver(ServiceWorkerContextWrapper* context)

@@ -182,7 +182,7 @@ class WorkerActivatedObserver

void Init() {

RunOnIOThread(base::Bind(&WorkerActivatedObserver::InitOnIOThread, this));

}

- // ServiceWorkerContextObserver overrides.

+ // ServiceWorkerContextCoreObserver overrides.

void OnVersionStateChanged(int64_t version_id,

ServiceWorkerVersion::Status) override {

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

@@ -520,14 +520,14 @@ class ConsoleListener : public EmbeddedWorkerInstance::Listener {

// Listens to console messages on ServiceWorkerContextWrapper.

class ConsoleMessageContextObserver

- : public ServiceWorkerContextObserver,

+ : public ServiceWorkerContextCoreObserver,

public base::RefCountedThreadSafe<ConsoleMessageContextObserver> {

public:

explicit ConsoleMessageContextObserver(ServiceWorkerContextWrapper* context)

: context_(context) {}

void Init() { context_->AddObserver(this); }

- // ServiceWorkerContextObserver overrides.

+ // ServiceWorkerContextCoreObserver overrides.

void OnReportConsoleMessage(int64_t version_id,

int process_id,

int thread_id,