Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2930513002: Modify PrinterSetupResult enum to constant style. (Closed)

Created:
3 years, 6 months ago by skau
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Modify PrinterSetupResult enum to constant style. We've moved away from MACRO_STYLE to kConstantStyle for enum names. Migrate PrinterSetupResult so we don't get a conflict later. BUG=725741 Review-Url: https://codereview.chromium.org/2906633004 Cr-Original-Commit-Position: refs/heads/master@{#475115} Review-Url: https://codereview.chromium.org/2930513002 . Cr-Commit-Position: refs/branch-heads/3112@{#208} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/09def8539a8eb76e51911302fb2143b7071bdc31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -37 lines) Patch
M chrome/browser/chromeos/printer_detector/cups_printer_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/printer_configurer.h View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/printing/printer_configurer.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
skau
3 years, 6 months ago (2017-06-06 21:14:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09def8539a8eb76e51911302fb2143b7071bdc31.

Powered by Google App Engine
This is Rietveld 408576698