Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5679)

Unified Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2930513002: Modify PrinterSetupResult enum to constant style. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
index 730e2e3f93ef61e319c9aae0f17edad81a4ff368..2d1181a17ed7e5521625ae97f6e861f751441f56 100644
--- a/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
+++ b/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
@@ -257,35 +257,38 @@ void CupsPrintersHandler::OnAddedPrinter(
chromeos::PrinterSetupResult result_code) {
std::string printer_name = printer->display_name();
switch (result_code) {
- case chromeos::PrinterSetupResult::SUCCESS: {
+ case chromeos::PrinterSetupResult::kSuccess: {
auto* manager = PrintersManagerFactory::GetForBrowserContext(profile_);
manager->PrinterInstalled(*printer);
manager->RegisterPrinter(std::move(printer));
break;
}
- case chromeos::PrinterSetupResult::PPD_NOT_FOUND:
+ case chromeos::PrinterSetupResult::kPpdNotFound:
LOG(WARNING) << "Could not locate requested PPD";
break;
- case chromeos::PrinterSetupResult::PPD_TOO_LARGE:
+ case chromeos::PrinterSetupResult::kPpdTooLarge:
LOG(WARNING) << "PPD is too large";
break;
- case chromeos::PrinterSetupResult::PPD_UNRETRIEVABLE:
+ case chromeos::PrinterSetupResult::kPpdUnretrievable:
LOG(WARNING) << "Could not retrieve PPD from server";
break;
- case chromeos::PrinterSetupResult::INVALID_PPD:
+ case chromeos::PrinterSetupResult::kInvalidPpd:
LOG(WARNING) << "Provided PPD is invalid.";
break;
- case chromeos::PrinterSetupResult::PRINTER_UNREACHABLE:
+ case chromeos::PrinterSetupResult::kPrinterUnreachable:
LOG(WARNING) << "Could not contact printer for configuration";
break;
- case chromeos::PrinterSetupResult::DBUS_ERROR:
- case chromeos::PrinterSetupResult::FATAL_ERROR:
+ case chromeos::PrinterSetupResult::kDbusError:
+ case chromeos::PrinterSetupResult::kFatalError:
LOG(ERROR) << "Unrecoverable error. Reboot required.";
break;
+ case chromeos::PrinterSetupResult::kMaxValue:
+ NOTREACHED() << "This is not an expected value";
+ break;
}
CallJavascriptFunction(
"cr.webUIListenerCallback", base::Value("on-add-cups-printer"),
- base::Value(result_code == chromeos::PrinterSetupResult::SUCCESS),
+ base::Value(result_code == chromeos::PrinterSetupResult::kSuccess),
base::Value(printer_name));
}
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698