Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2930513002: Modify PrinterSetupResult enum to constant style. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h" 5 #include "chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 printer_copy, 250 printer_copy,
251 base::Bind(&CupsPrintersHandler::OnAddedPrinter, 251 base::Bind(&CupsPrintersHandler::OnAddedPrinter,
252 weak_factory_.GetWeakPtr(), base::Passed(&printer))); 252 weak_factory_.GetWeakPtr(), base::Passed(&printer)));
253 } 253 }
254 254
255 void CupsPrintersHandler::OnAddedPrinter( 255 void CupsPrintersHandler::OnAddedPrinter(
256 std::unique_ptr<Printer> printer, 256 std::unique_ptr<Printer> printer,
257 chromeos::PrinterSetupResult result_code) { 257 chromeos::PrinterSetupResult result_code) {
258 std::string printer_name = printer->display_name(); 258 std::string printer_name = printer->display_name();
259 switch (result_code) { 259 switch (result_code) {
260 case chromeos::PrinterSetupResult::SUCCESS: { 260 case chromeos::PrinterSetupResult::kSuccess: {
261 auto* manager = PrintersManagerFactory::GetForBrowserContext(profile_); 261 auto* manager = PrintersManagerFactory::GetForBrowserContext(profile_);
262 manager->PrinterInstalled(*printer); 262 manager->PrinterInstalled(*printer);
263 manager->RegisterPrinter(std::move(printer)); 263 manager->RegisterPrinter(std::move(printer));
264 break; 264 break;
265 } 265 }
266 case chromeos::PrinterSetupResult::PPD_NOT_FOUND: 266 case chromeos::PrinterSetupResult::kPpdNotFound:
267 LOG(WARNING) << "Could not locate requested PPD"; 267 LOG(WARNING) << "Could not locate requested PPD";
268 break; 268 break;
269 case chromeos::PrinterSetupResult::PPD_TOO_LARGE: 269 case chromeos::PrinterSetupResult::kPpdTooLarge:
270 LOG(WARNING) << "PPD is too large"; 270 LOG(WARNING) << "PPD is too large";
271 break; 271 break;
272 case chromeos::PrinterSetupResult::PPD_UNRETRIEVABLE: 272 case chromeos::PrinterSetupResult::kPpdUnretrievable:
273 LOG(WARNING) << "Could not retrieve PPD from server"; 273 LOG(WARNING) << "Could not retrieve PPD from server";
274 break; 274 break;
275 case chromeos::PrinterSetupResult::INVALID_PPD: 275 case chromeos::PrinterSetupResult::kInvalidPpd:
276 LOG(WARNING) << "Provided PPD is invalid."; 276 LOG(WARNING) << "Provided PPD is invalid.";
277 break; 277 break;
278 case chromeos::PrinterSetupResult::PRINTER_UNREACHABLE: 278 case chromeos::PrinterSetupResult::kPrinterUnreachable:
279 LOG(WARNING) << "Could not contact printer for configuration"; 279 LOG(WARNING) << "Could not contact printer for configuration";
280 break; 280 break;
281 case chromeos::PrinterSetupResult::DBUS_ERROR: 281 case chromeos::PrinterSetupResult::kDbusError:
282 case chromeos::PrinterSetupResult::FATAL_ERROR: 282 case chromeos::PrinterSetupResult::kFatalError:
283 LOG(ERROR) << "Unrecoverable error. Reboot required."; 283 LOG(ERROR) << "Unrecoverable error. Reboot required.";
284 break; 284 break;
285 case chromeos::PrinterSetupResult::kMaxValue:
286 NOTREACHED() << "This is not an expected value";
287 break;
285 } 288 }
286 CallJavascriptFunction( 289 CallJavascriptFunction(
287 "cr.webUIListenerCallback", base::Value("on-add-cups-printer"), 290 "cr.webUIListenerCallback", base::Value("on-add-cups-printer"),
288 base::Value(result_code == chromeos::PrinterSetupResult::SUCCESS), 291 base::Value(result_code == chromeos::PrinterSetupResult::kSuccess),
289 base::Value(printer_name)); 292 base::Value(printer_name));
290 } 293 }
291 294
292 void CupsPrintersHandler::OnAddPrinterError() { 295 void CupsPrintersHandler::OnAddPrinterError() {
293 FireWebUIListener("on-add-cups-printer", base::Value(false), base::Value("")); 296 FireWebUIListener("on-add-cups-printer", base::Value(false), base::Value(""));
294 } 297 }
295 298
296 void CupsPrintersHandler::HandleGetCupsPrinterManufacturers( 299 void CupsPrintersHandler::HandleGetCupsPrinterManufacturers(
297 const base::ListValue* args) { 300 const base::ListValue* args) {
298 AllowJavascript(); 301 AllowJavascript();
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 FireWebUIListener("on-printer-discovered", *printers_list); 414 FireWebUIListener("on-printer-discovered", *printers_list);
412 } 415 }
413 416
414 void CupsPrintersHandler::OnDiscoveryInitialScanDone(int printer_count) { 417 void CupsPrintersHandler::OnDiscoveryInitialScanDone(int printer_count) {
415 UMA_HISTOGRAM_COUNTS_100("Printing.CUPS.PrintersDiscovered", printer_count); 418 UMA_HISTOGRAM_COUNTS_100("Printing.CUPS.PrintersDiscovered", printer_count);
416 FireWebUIListener("on-printer-discovery-done"); 419 FireWebUIListener("on-printer-discovery-done");
417 } 420 }
418 421
419 } // namespace settings 422 } // namespace settings
420 } // namespace chromeos 423 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698