Modify PrinterSetupResult enum to constant style.

Modify PrinterSetupResult enum to constant style.

We've moved away from MACRO_STYLE to kConstantStyle for enum names.
Migrate PrinterSetupResult so we don't get a conflict later.

BUG=725741
Review-Url: https://codereview.chromium.org/2906633004
Cr-Commit-Position: refs/heads/master@{#475115}
Committed: https://chromium.googlesource.com/chromium/src/+/4b97690be1738233d04011eee439dd58b17eb05b

[skau, 2017-05-25 22:37:48]

skau@chromium.org changed reviewers:
+ justincarlson@chromium.org, thestig@chromium.org

[skau, 2017-05-25 22:37:49]

Per https://groups.google.com/a/chromium.org/forum/#!topic/cxx/Hpkfudv5bac we've
changed enum style.  Somebody will probably fix the whole codebase later.  But
since I'm using the enum, I'll migrate this now.

[Lei Zhang, 2017-05-25 22:53:04]

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/printer_configurer.h (right):

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/printer_configurer.h:22: // Space left for
additional errors
Can you explain why this is needed?

[skau, 2017-05-25 23:11:08]

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/printer_configurer.h (right):

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/printer_configurer.h:22: // Space left for
additional errors
On 2017/05/25 22:53:03, Lei Zhang wrote:
> Can you explain why this is needed?

I'm leaving space for non-PPD errors and thought it might be nice.  There's no
logic that depends on this right now.  Is there a significant downside?

[Lei Zhang, 2017-05-25 23:24:07]

lgtm

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/printing/printer_configurer.h (right):

https://codereview.chromium.org/2906633004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/printing/printer_configurer.h:22: // Space left for
additional errors
On 2017/05/25 23:11:07, skau wrote:
> On 2017/05/25 22:53:03, Lei Zhang wrote:
> > Can you explain why this is needed?
> 
> I'm leaving space for non-PPD errors and thought it might be nice.  There's no
> logic that depends on this right now.  Is there a significant downside?

OK, the CL description hinted that you are going to use these for something. I
noticed https://codereview.chromium.org/2911523002 now. I didn't see it before
so I wasn't sure where you were going with this.

[skau, 2017-05-26 17:38:22]

Description was changed from

==========
Modify PrinterSetupResult enum to constant style.

We've moved away from MACRO_STYLE to kConstantStyle for enum names.
Migrate PrinterSetupResult so we don't get a conflict later.

BUG=
==========

to

==========
Modify PrinterSetupResult enum to constant style.

We've moved away from MACRO_STYLE to kConstantStyle for enum names.
Migrate PrinterSetupResult so we don't get a conflict later.

BUG=725741
==========

[skau, 2017-05-26 17:38:55]

FYI: I changed the kMaxValue and added a comment.
justincarlson@: Do you want to take a look before I submit?

[Carlson, 2017-05-26 20:07:40]

lgtm

https://codereview.chromium.org/2906633004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
(right):

https://codereview.chromium.org/2906633004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc:178:
NOTREACHED() << "This value is not exepcted";
expected

[skau, 2017-05-26 20:10:11]

The CQ bit was checked by skau@chromium.org

[skau, 2017-05-26 20:10:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, justincarlson@chromium.org
Link to the patchset: https://codereview.chromium.org/2906633004/#ps60001
(title: "typo")

[skau, 2017-05-26 20:10:20]

Thanks for the review.

https://codereview.chromium.org/2906633004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
(right):

https://codereview.chromium.org/2906633004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc:178:
NOTREACHED() << "This value is not exepcted";
On 2017/05/26 20:07:40, Carlson wrote:
> expected

Done.

[commit-bot: I haz the power, 2017-05-26 20:10:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:40:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495829411431970,
"parent_rev": "9b7060c78d0c6ec8f831823bf9fff9946eece7d4", "commit_rev":
"4b97690be1738233d04011eee439dd58b17eb05b"}

[commit-bot: I haz the power, 2017-05-26 20:41:11]

Description was changed from

==========
Modify PrinterSetupResult enum to constant style.

We've moved away from MACRO_STYLE to kConstantStyle for enum names.
Migrate PrinterSetupResult so we don't get a conflict later.

BUG=725741
==========

to

==========
Modify PrinterSetupResult enum to constant style.

We've moved away from MACRO_STYLE to kConstantStyle for enum names.
Migrate PrinterSetupResult so we don't get a conflict later.

BUG=725741

Review-Url: https://codereview.chromium.org/2906633004
Cr-Commit-Position: refs/heads/master@{#475115}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b97690be1738233d04011eee439...
==========

[commit-bot: I haz the power, 2017-05-26 20:41:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4b97690be1738233d04011eee439...