Issue 293009: Mark assembly routines that don't need to be exported as hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293009: Mark assembly routines that don't need to be exported as hidden (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
robertm

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Visibility:
Public.

Description

Mark assembly routines that don't need to be exported as .private_extern (Mac) or .hidden (Linux) BUG=http://crbug.com/24911 TEST=nm C.app/Contents/Versions/*/C F.framework/C F | grep " [A-TV-Z] " should not show any NaCl symbols. _NaClSwitch and _NaClSyscallSeg formerly showed up in the symbol table. Committed: http://code.google.com/p/nativeclient/source/detail?r=878

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -49 lines)			Patch
M	native_client/src/trusted/service_runtime/arch/arm/nacl_switch.S	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/arm/nacl_syscall.S	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/arm/nacl_tls_tramp.S	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/arm/springboard.S	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/arm/tramp.S	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_32/nacl_switch.S	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_32/nacl_syscall.S	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_32/nacl_syscall_weak.S	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_32/springboard.S	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_32/tramp.S	View	1 chunk	+18 lines, -14 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_64/nacl_switch.S	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	native_client/src/trusted/service_runtime/nacl_config.h	View	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I fed this to the Chromium Mac, Linux, and Windows try servers, and they all ...

11 years, 2 months ago (2009-10-19 21:27:47 UTC) #1

robertm

11 years, 2 months ago (2009-10-19 21:47:25 UTC) #2

LGTM

On 2009/10/19 21:27:47, Mark Mentovai wrote:
> I fed this to the Chromium Mac, Linux, and Windows try servers, and they all
> compiled it successfully.

Expand Messages | Collapse Messages