Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: native_client/src/trusted/service_runtime/nacl_config.h

Issue 293009: Mark assembly routines that don't need to be exported as hidden (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client/src/trusted/service_runtime/nacl_config.h
===================================================================
--- native_client/src/trusted/service_runtime/nacl_config.h (revision 877)
+++ native_client/src/trusted/service_runtime/nacl_config.h (working copy)
@@ -120,7 +120,8 @@
#define NACL_TRAMPOLINE_END (NACL_TRAMPOLINE_START + NACL_TRAMPOLINE_SIZE)
/*
* macros to provide uniform access to identifiers from assembly due
- * to different C -> asm name mangling convention
+ * to different C -> asm name mangling conventions and other platform-specific
+ * requirements
*/
#if NACL_WINDOWS || NACL_OSX
# define IDENTIFIER(n) _##n
@@ -128,6 +129,15 @@
# define IDENTIFIER(n) n
#endif
+#if NACL_OSX
+# define HIDDEN(n) .private_extern IDENTIFIER(n)
+#elif NACL_LINUX
+# define HIDDEN(n) .hidden IDENTIFIER(n)
+#else /* Windows */
+/* On Windows, symbols are hidden by default. */
+# define HIDDEN(n)
+#endif
+
#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_x86
#if NACL_BUILD_SUBARCH == 32
« no previous file with comments | « native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698