native_client/src/trusted/service_runtime/arch/arm/nacl_syscall.S - Issue 293009: Mark assembly routines that don't need to be exported as hidden

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client/src/trusted/service_runtime/arch/arm/nacl_syscall.S

Issue 293009: Mark assembly routines that don't need to be exported as hidden (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « native_client/src/trusted/service_runtime/arch/arm/nacl_switch.S ('k') | native_client/src/trusted/service_runtime/arch/arm/nacl_tls_tramp.S » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright 2009, Google Inc.	2 * Copyright 2009, Google Inc.

3 * All rights reserved.	3 * All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 * top	43 * top

44 * =====	44 * =====

45 * r0 - alignment for NaClSyscallCSegHook	45 * r0 - alignment for NaClSyscallCSegHook

46 * lr - return address	46 * lr - return address

47 * arg 1	47 * arg 1

48 * arg 2	48 * arg 2

49 * .....	49 * .....

50 * arg N	50 * arg N

51 */	51 */

52	52

53 .globl IDENTIFIER(nacl_user)	53 .globl IDENTIFIER(NaClSyscallSeg)

54 .globl IDENTIFIER(nacl_sys)	54 HIDDEN(NaClSyscallSeg)

55

56 .globl IDENTIFIER(NaClSyscallCSegHook)

57 .globl IDENTIFIER(NaClSyscallSeg)

58

59 IDENTIFIER(NaClSyscallSeg):	55 IDENTIFIER(NaClSyscallSeg):

60	56

61 push {lr}	57 push {lr}

62	58

63 /*	59 /*

64 * TLS_IDX represents address of a TLS region and index in	60 * TLS_IDX represents address of a TLS region and index in

65 * nacl_thread/nacl_user/nacl_sys arrays. The TLS region is paged aligned;	61 * nacl_thread/nacl_user/nacl_sys arrays. The TLS region is paged aligned;

66 * therefore, we use the lowest 12 bits to store the thread index	62 * therefore, we use the lowest 12 bits to store the thread index

67 */	63 */

68	64

(...skipping 18 matching lines...) Expand all Loading...
87 bl NaClSyscallCSegHook	83 bl NaClSyscallCSegHook

88	84

89 /* NOTREACHED */	85 /* NOTREACHED */

90	86

91 /*	87 /*

92 * if the thread returns, which must not happen, it will be halted	88 * if the thread returns, which must not happen, it will be halted

93 * by the following instruction	89 * by the following instruction

94 */	90 */

95	91

96 NACL_HALT	92 NACL_HALT

OLD	NEW