native_client/src/trusted/service_runtime/arch/x86_32/springboard.S - Issue 293009: Mark assembly routines that don't need to be exported as hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client/src/trusted/service_runtime/arch/x86_32/springboard.S

Issue 293009: Mark assembly routines that don't need to be exported as hidden (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client/src/trusted/service_runtime/arch/x86_32/nacl_syscall_weak.S ('k') | native_client/src/trusted/service_runtime/arch/x86_32/tramp.S » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client/src/trusted/service_runtime/arch/x86_32/springboard.S

===================================================================

--- native_client/src/trusted/service_runtime/arch/x86_32/springboard.S (revision 877)

+++ native_client/src/trusted/service_runtime/arch/x86_32/springboard.S (working copy)

@@ -42,14 +42,13 @@

* region.

- .globl IDENTIFIER(NaCl_springboard)

- .globl IDENTIFIER(NaCl_springboard_end)

- * NaCl_pringboard is used for syscall return and any time we want

+ * NaCl_springboard is used for syscall return and any time we want

* to do an upcall into NaCl application.

+.globl IDENTIFIER(NaCl_springboard)

+ HIDDEN(NaCl_springboard)

IDENTIFIER(NaCl_springboard):

hlt /* one byte */

/* syscall return value, if any, from trusted stack */

@@ -57,4 +56,6 @@

lss 0x1c(%ecx), %esp /* stack_ptr.ptr_32.ptr */

mov 0x28(%ecx), %ds /* ds */

jmp *%edx

+.globl IDENTIFIER(NaCl_springboard_end)

+ HIDDEN(NaCl_springboard_end)

IDENTIFIER(NaCl_springboard_end):