native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S - Issue 293009: Mark assembly routines that don't need to be exported as hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S

Issue 293009: Mark assembly routines that don't need to be exported as hidden (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client/src/trusted/service_runtime/arch/x86_64/nacl_switch.S ('k') | native_client/src/trusted/service_runtime/nacl_config.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S

===================================================================

--- native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S (revision 877)

+++ native_client/src/trusted/service_runtime/arch/x86_64/nacl_syscall.S (working copy)

@@ -40,11 +40,8 @@

#include "native_client/src/trusted/service_runtime/nacl_config.h"

- .globl IDENTIFIER(nacl_user)

- .globl IDENTIFIER(nacl_sys)

- .globl IDENTIFIER(NaClSyscallCSegHook)

- .globl IDENTIFIER(NaClSyscallSeg)

+.globl IDENTIFIER(NaClSyscallSeg)

+ HIDDEN(NaClSyscallSeg)

IDENTIFIER(NaClSyscallSeg):

* As far as we know, glibc-derived code always explicitly clears