third_party/WebKit/Source/platform/graphics/Pattern.h - Issue 2928703005: Revert of cc: Move SkShader construction to a single spot in PaintShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Pattern.h

Issue 2928703005: Revert of cc: Move SkShader construction to a single spot in PaintShader (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Pattern.h

diff --git a/third_party/WebKit/Source/platform/graphics/Pattern.h b/third_party/WebKit/Source/platform/graphics/Pattern.h

index f939b5ee16a7407e28d02d8f02296e7cdc35aa01..1db8d22bed04bc1525b799d300cfb2fa74beeaf5 100644

--- a/third_party/WebKit/Source/platform/graphics/Pattern.h

+++ b/third_party/WebKit/Source/platform/graphics/Pattern.h

@@ -72,13 +72,13 @@

virtual bool IsTextureBacked() const { return false; }

protected:

- virtual std::unique_ptr<PaintShader> CreateShader(const SkMatrix&) = 0;

+ virtual sk_sp<PaintShader> CreateShader(const SkMatrix&) = 0;

virtual bool IsLocalMatrixChanged(const SkMatrix&) const;

RepeatMode repeat_mode_;

Pattern(RepeatMode);

- mutable std::unique_ptr<PaintShader> cached_shader_;

+ mutable sk_sp<PaintShader> cached_shader_;

};

} // namespace blink