Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2926643003: [VrShell] Centralize color handling and enable close button on fullscreen (Closed)

Created:
3 years, 6 months ago by amp
Modified:
3 years, 6 months ago
Reviewers:
cjgrant
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[VrShell] Centralize color handling and enable close button on fullscreen This updates all of the existing hard coded colors to use colors from the scheme instead of hardcoding (so they can change with the mode). The naming of colors in the scheme was also updated for better consistency and to differentiate from world environment colors. BUG=719997, 729729 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2914623003 Cr-Original-Commit-Position: refs/heads/master@{#477411} Review-Url: https://codereview.chromium.org/2926643003 Cr-Commit-Position: refs/branch-heads/3112@{#225} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ed05197a31887a41b469403b2b497e21bff20c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -126 lines) Patch
M chrome/browser/android/vr_shell/color_scheme.h View 2 chunks +27 lines, -12 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 1 chunk +47 lines, -23 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/button_texture.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/button_texture.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/close_button_texture.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/exit_warning_texture.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/system_indicator_texture.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/ui_texture.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/screen_dimmer.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/textured_element.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 8 chunks +42 lines, -13 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 4 chunks +34 lines, -16 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
amp
drover merge to 60, need committer lgtm
3 years, 6 months ago (2017-06-07 17:05:09 UTC) #3
cjgrant
lgtm
3 years, 6 months ago (2017-06-07 17:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926643003/1
3 years, 6 months ago (2017-06-07 17:24:22 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 17:25:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed05197a31887a41b469403b2b49...

Powered by Google App Engine
This is Rietveld 408576698