Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2926313002: Revert of [cast_channel] Move cast_channel related files from //extensions to //components (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
CC:
blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, droger+watchlist_chromium.org, extensions-reviews_chromium.org, mfoltz+watch_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [cast_channel] Move cast_channel related files from //extensions to //components (patchset #8 id:160001 of https://codereview.chromium.org/2913033003/ ) Reason for revert: Broke Google Chrome ChromeOS builder's compile: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/34886 Original issue's description: > [cast_channel] Move cast_channel related files from //extensions to //components > > - Move files > - Updated namespace: extensions::api::cast_channel => ::cast_channel > - Updated unit tests > > BUG=723944 > > Review-Url: https://codereview.chromium.org/2913033003 > Cr-Commit-Position: refs/heads/master@{#478022} > Committed: https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac56eeb10648cd6 TBR=jochen@chromium.org,imcheng@chromium.org,mfoltz@chromium.org,rdevlin.cronin@chromium.org,zhaobin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=723944 Review-Url: https://codereview.chromium.org/2926313002 Cr-Commit-Position: refs/heads/master@{#478027} Committed: https://chromium.googlesource.com/chromium/src/+/660596576a7c7b49050108af154f44ce3955ddc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6347 lines, -6290 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cast_channel/BUILD.gn View 1 chunk +0 lines, -67 lines 0 comments Download
D components/cast_channel/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/cast_channel/cast_auth_util.h View 1 chunk +0 lines, -122 lines 0 comments Download
D components/cast_channel/cast_auth_util.cc View 1 chunk +0 lines, -394 lines 0 comments Download
D components/cast_channel/cast_auth_util_unittest.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D components/cast_channel/cast_framer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/cast_channel/cast_framer.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D components/cast_channel/cast_framer_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D components/cast_channel/cast_message_util.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/cast_channel/cast_message_util.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D components/cast_channel/cast_socket.h View 1 chunk +0 lines, -394 lines 0 comments Download
D components/cast_channel/cast_socket.cc View 1 chunk +0 lines, -610 lines 0 comments Download
D components/cast_channel/cast_socket_service.h View 1 chunk +0 lines, -58 lines 0 comments Download
D components/cast_channel/cast_socket_service.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D components/cast_channel/cast_socket_service_factory.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/cast_channel/cast_socket_service_factory.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D components/cast_channel/cast_socket_service_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D components/cast_channel/cast_socket_unittest.cc View 1 chunk +0 lines, -780 lines 0 comments Download
D components/cast_channel/cast_test_util.h View 1 chunk +0 lines, -121 lines 0 comments Download
D components/cast_channel/cast_test_util.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D components/cast_channel/cast_transport.h View 1 chunk +0 lines, -227 lines 0 comments Download
D components/cast_channel/cast_transport.cc View 1 chunk +0 lines, -450 lines 0 comments Download
D components/cast_channel/cast_transport_unittest.cc View 1 chunk +0 lines, -682 lines 0 comments Download
D components/cast_channel/keep_alive_delegate.h View 1 chunk +0 lines, -113 lines 0 comments Download
D components/cast_channel/keep_alive_delegate.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D components/cast_channel/keep_alive_delegate_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D components/cast_channel/logger.h View 1 chunk +0 lines, -82 lines 0 comments Download
D components/cast_channel/logger.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D components/cast_channel/logger_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/cast_channel/proto/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D components/cast_channel/proto/authority_keys.proto View 1 chunk +0 lines, -17 lines 0 comments Download
D components/cast_channel/proto/cast_channel.proto View 1 chunk +0 lines, -99 lines 0 comments Download
D components/cast_channel/proto/logging.proto View 1 chunk +0 lines, -174 lines 0 comments Download
M extensions/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/cast_channel/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_auth_util.h View 1 chunk +126 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_auth_util.cc View 1 chunk +399 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_auth_util_unittest.cc View 1 chunk +339 lines, -0 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.h View 8 chunks +25 lines, -22 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.cc View 13 chunks +34 lines, -40 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 5 chunks +20 lines, -17 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_enum_util_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_framer.h View 1 chunk +105 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_framer.cc View 1 chunk +181 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_framer_unittest.cc View 1 chunk +143 lines, -0 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.h View 1 chunk +22 lines, -6 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.cc View 5 chunks +91 lines, -22 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket.h View 1 chunk +402 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket.cc View 1 chunk +620 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_service.h View 1 chunk +62 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_service.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_service_factory.h View 1 chunk +50 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_service_factory.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_service_unittest.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_socket_unittest.cc View 1 chunk +794 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_test_util.h View 1 chunk +127 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_test_util.cc View 1 chunk +47 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_transport.h View 1 chunk +231 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_transport.cc View 1 chunk +455 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/cast_transport_unittest.cc View 1 chunk +687 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/keep_alive_delegate.h View 1 chunk +117 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/keep_alive_delegate.cc View 1 chunk +200 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/keep_alive_delegate_unittest.cc View 1 chunk +219 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/logger.h View 1 chunk +87 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/logger.cc View 1 chunk +156 lines, -0 lines 0 comments Download
A extensions/browser/api/cast_channel/logger_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A extensions/common/api/cast_channel/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A extensions/common/api/cast_channel/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A extensions/common/api/cast_channel/authority_keys.proto View 1 chunk +17 lines, -0 lines 0 comments Download
A extensions/common/api/cast_channel/cast_channel.proto View 1 chunk +101 lines, -0 lines 0 comments Download
A extensions/common/api/cast_channel/logging.proto View 1 chunk +172 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
Created Revert of [cast_channel] Move cast_channel related files from //extensions to //components
3 years, 6 months ago (2017-06-08 18:22:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926313002/1
3 years, 6 months ago (2017-06-08 18:22:59 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 18:24:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/660596576a7c7b49050108af154f...

Powered by Google App Engine
This is Rietveld 408576698