[cast_channel] Move cast_channel related files from //extensions to //components

[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944
Review-Url: https://codereview.chromium.org/2913033003
Cr-Original-Commit-Position: refs/heads/master@{#478022}
Committed: https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac56eeb10648cd6
Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478116}
Committed: https://chromium.googlesource.com/chromium/src/+/aa0a64440d8045e9ee0962ed1a1d7386a24d5921

[zhaobin, 2017-05-31 01:47:31]

zhaobin@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[mark a. foltz, 2017-06-01 21:26:36]

LGTM % some minor fixes

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/BUI...
File components/cast_channel/BUILD.gn (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/BUI...
components/cast_channel/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
2017

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/DEPS
File components/cast_channel/DEPS (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/DEP...
components/cast_channel/DEPS:8: "+third_party/zlib",
Is this still required?

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
File components/cast_channel/proto/OWNERS (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
components/cast_channel/proto/OWNERS:1: mfoltz@chromium.org
This file seems to be identical to the parent OWNERS file.  Can it be deleted?

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
File components/cast_channel/proto/logging.proto (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
components/cast_channel/proto/logging.proto:4: 
Can you add a TODO(crbug.com/513801) to replace this file with plain
enums/structs?

We no longer serialize this data or need to aggregate events, so it doesn't need
to be defined as a protocol message.

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_channel_api.cc (right):

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_channel_api.cc:43: namespace
cast_channel = api::cast_channel;
I think this ends up being very similar to ::cast_channel and potentially
confusing.  Can it be removed?  I don't see any uses in the code below apart
from the namespace statements.

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_channel_apitest.cc (right):

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_channel_apitest.cc:33: // TODO(mfoltz):
Mock out the ApiResourceManager to resolve threading issues
This TODO is obsolete, can it be removed?

[zhaobin, 2017-06-01 21:59:59]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[zhaobin, 2017-06-01 22:00:38]

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/BUI...
File components/cast_channel/BUILD.gn (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/BUI...
components/cast_channel/BUILD.gn:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
On 2017/06/01 21:26:35, mark a. foltz wrote:
> 2017

Done.

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/DEPS
File components/cast_channel/DEPS (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/DEP...
components/cast_channel/DEPS:8: "+third_party/zlib",
On 2017/06/01 21:26:35, mark a. foltz wrote:
> Is this still required?

Done.

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
File components/cast_channel/proto/OWNERS (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
components/cast_channel/proto/OWNERS:1: mfoltz@chromium.org
On 2017/06/01 21:26:35, mark a. foltz wrote:
> This file seems to be identical to the parent OWNERS file.  Can it be deleted?

Done.

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
File components/cast_channel/proto/logging.proto (right):

https://codereview.chromium.org/2913033003/diff/1/components/cast_channel/pro...
components/cast_channel/proto/logging.proto:4: 
On 2017/06/01 21:26:35, mark a. foltz wrote:
> Can you add a TODO(crbug.com/513801) to replace this file with plain
> enums/structs?
> 
> We no longer serialize this data or need to aggregate events, so it doesn't
need
> to be defined as a protocol message.

Done.

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_channel_api.cc (right):

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_channel_api.cc:43: namespace
cast_channel = api::cast_channel;
On 2017/06/01 21:26:35, mark a. foltz wrote:
> I think this ends up being very similar to ::cast_channel and potentially
> confusing.  Can it be removed?  I don't see any uses in the code below apart
> from the namespace statements.

Done.

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
File extensions/browser/api/cast_channel/cast_channel_apitest.cc (right):

https://codereview.chromium.org/2913033003/diff/1/extensions/browser/api/cast...
extensions/browser/api/cast_channel/cast_channel_apitest.cc:33: // TODO(mfoltz):
Mock out the ApiResourceManager to resolve threading issues
On 2017/06/01 21:26:35, mark a. foltz wrote:
> This TODO is obsolete, can it be removed?

Done.

[commit-bot: I haz the power, 2017-06-01 22:00:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 22:05:27]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[zhaobin, 2017-06-01 23:06:58]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 23:07:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:13:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[zhaobin, 2017-06-02 00:04:18]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 00:05:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:33:15]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[zhaobin, 2017-06-02 06:10:41]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 06:10:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 06:47:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 06:47:26]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[zhaobin, 2017-06-02 18:23:31]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 18:23:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[imcheng, 2017-06-02 19:53:06]

lgtm

[commit-bot: I haz the power, 2017-06-02 21:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:55:22]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-06-02 22:18:33]

zhaobin@chromium.org changed reviewers:
+ jochen@chromium.org, rdevlin.cronin@chromium.org

[zhaobin, 2017-06-02 22:18:35]

+jochen@ to review components/*

+rdevlin.cronin@ to review extensions/*

[Devlin, 2017-06-05 14:05:45]

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
File extensions/browser/api/cast_channel/cast_channel_api.h (right):

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
extensions/browser/api/cast_channel/cast_channel_api.h:41: namespace
cast_channel = api::cast_channel;
Is this the declaration that's causing the need to prefix cast_channel::
everywhere else?

For one thing, namespace aliases/usings are forbidden in .h files (because it
pollutes all files that include it), so we should remove this regardless.  If we
do that, does that clean the rest up?

[zhaobin, 2017-06-05 23:59:26]

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
File extensions/browser/api/cast_channel/cast_channel_api.h (right):

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
extensions/browser/api/cast_channel/cast_channel_api.h:41: namespace
cast_channel = api::cast_channel;
On 2017/06/05 14:05:45, Devlin wrote:
> Is this the declaration that's causing the need to prefix cast_channel::
> everywhere else?
> 
> For one thing, namespace aliases/usings are forbidden in .h files (because it
> pollutes all files that include it), so we should remove this regardless.  If
we
> do that, does that clean the rest up?

namespace using removed.

Seems not able to clean the rest up. CastChannelAPi Class is defined in
namespace extensions, and trying to use classes defined in
extensions::api::cast_channel and cast_channel. Namespace prefix seems necessary
here.

[jochen (gone - plz use gerrit), 2017-06-06 14:55:43]

rubberstamp lgtm

[zhaobin, 2017-06-08 06:11:45]

Patchset #8 (id:140001) has been deleted

[zhaobin, 2017-06-08 06:13:16]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 06:13:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 07:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 07:49:14]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-08 14:56:34]

extensions rs lgtm

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
File extensions/browser/api/cast_channel/cast_channel_api.h (right):

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
extensions/browser/api/cast_channel/cast_channel_api.h:41: namespace
cast_channel = api::cast_channel;
On 2017/06/05 23:59:26, zhaobin wrote:
> On 2017/06/05 14:05:45, Devlin wrote:
> > Is this the declaration that's causing the need to prefix cast_channel::
> > everywhere else?
> > 
> > For one thing, namespace aliases/usings are forbidden in .h files (because
it
> > pollutes all files that include it), so we should remove this regardless. 
If
> we
> > do that, does that clean the rest up?
> 
> namespace using removed.
> 
> Seems not able to clean the rest up. CastChannelAPi Class is defined in
> namespace extensions, and trying to use classes defined in
> extensions::api::cast_channel and cast_channel. Namespace prefix seems
necessary
> here.

Dang.  Having three separate "cast_channel" namespaces (::cast_channel,
extensions::cast_channel, extensions::api::cast_channel) is pretty unfortunate. 
This need not block this CL, but can we think about how to make that better? 
(Removing some of them if they're no longer needed, renaming some to better
match content, etc)

[mark a. foltz, 2017-06-08 17:55:45]

On 2017/06/08 at 14:56:34, rdevlin.cronin wrote:
> extensions rs lgtm
> 
>
https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
> File extensions/browser/api/cast_channel/cast_channel_api.h (right):
> 
>
https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
> extensions/browser/api/cast_channel/cast_channel_api.h:41: namespace
cast_channel = api::cast_channel;
> On 2017/06/05 23:59:26, zhaobin wrote:
> > On 2017/06/05 14:05:45, Devlin wrote:
> > > Is this the declaration that's causing the need to prefix cast_channel::
> > > everywhere else?
> > > 
> > > For one thing, namespace aliases/usings are forbidden in .h files (because
it
> > > pollutes all files that include it), so we should remove this regardless. 
If
> > we
> > > do that, does that clean the rest up?
> > 
> > namespace using removed.
> > 
> > Seems not able to clean the rest up. CastChannelAPi Class is defined in
> > namespace extensions, and trying to use classes defined in
> > extensions::api::cast_channel and cast_channel. Namespace prefix seems
necessary
> > here.
> 
> Dang.  Having three separate "cast_channel" namespaces (::cast_channel,
extensions::cast_channel, extensions::api::cast_channel) is pretty unfortunate. 
This need not block this CL, but can we think about how to make that better? 
(Removing some of them if they're no longer needed, renaming some to better
match content, etc)

Where do you see extensions::cast_channel declared?

[zhaobin, 2017-06-08 17:57:00]

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
File extensions/browser/api/cast_channel/cast_channel_api.h (right):

https://codereview.chromium.org/2913033003/diff/100001/extensions/browser/api...
extensions/browser/api/cast_channel/cast_channel_api.h:41: namespace
cast_channel = api::cast_channel;
On 2017/06/08 14:56:34, Devlin (slow through June 8) wrote:
> On 2017/06/05 23:59:26, zhaobin wrote:
> > On 2017/06/05 14:05:45, Devlin wrote:
> > > Is this the declaration that's causing the need to prefix cast_channel::
> > > everywhere else?
> > > 
> > > For one thing, namespace aliases/usings are forbidden in .h files (because
> it
> > > pollutes all files that include it), so we should remove this regardless. 
> If
> > we
> > > do that, does that clean the rest up?
> > 
> > namespace using removed.
> > 
> > Seems not able to clean the rest up. CastChannelAPi Class is defined in
> > namespace extensions, and trying to use classes defined in
> > extensions::api::cast_channel and cast_channel. Namespace prefix seems
> necessary
> > here.
> 
> Dang.  Having three separate "cast_channel" namespaces (::cast_channel,
> extensions::cast_channel, extensions::api::cast_channel) is pretty
unfortunate. 
> This need not block this CL, but can we think about how to make that better? 
> (Removing some of them if they're no longer needed, renaming some to better
> match content, etc)

Sure. Created crbug.com/731189 to track namespace clean up.

[zhaobin, 2017-06-08 17:58:53]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-06-08 17:58:54]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
imcheng@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2913033003/#ps160001
(title: "rebase with master")

[commit-bot: I haz the power, 2017-06-08 17:59:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 18:06:32]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496944733337620,
"parent_rev": "0705a49d8d56f04b6178d0d8dceed9c83d2105fb", "commit_rev":
"ef17b2caaf8074034c714d759ac56eeb10648cd6"}

[commit-bot: I haz the power, 2017-06-08 18:06:43]

Description was changed from

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944
==========

to

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944

Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...
==========

[commit-bot: I haz the power, 2017-06-08 18:06:45]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...

[Dan Beam, 2017-06-08 18:22:20]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/2926313002/ by dbeam@chromium.org.

The reason for reverting is: Broke Google Chrome ChromeOS builder's compile:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrom....

[Dan Beam, 2017-06-08 18:33:30]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-06-08 18:33:32]

note, this also broke Mac builders:
https://build.chromium.org/p/chromium/builders/Mac/builds/28562

[findit-for-me, 2017-06-08 18:33:44]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 478022 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[zhaobin, 2017-06-08 20:27:25]

Description was changed from

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944

Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...
==========

to

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944

Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...
==========

[zhaobin, 2017-06-08 21:21:12]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 21:21:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 22:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 22:57:05]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-06-08 22:57:55]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-06-08 22:57:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
rdevlin.cronin@chromium.org, imcheng@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2913033003/#ps180001
(title: "fix buildbot compile errors")

[commit-bot: I haz the power, 2017-06-08 22:58:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 23:04:46]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1496962675299520,
"parent_rev": "f77d4b0816dfa75bb4e6ebc452ba5f8a7e941c30", "commit_rev":
"aa0a64440d8045e9ee0962ed1a1d7386a24d5921"}

[commit-bot: I haz the power, 2017-06-08 23:05:04]

Description was changed from

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944

Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...
==========

to

==========
[cast_channel] Move cast_channel related files from //extensions to //components

- Move files
- Updated namespace: extensions::api::cast_channel => ::cast_channel
- Updated unit tests

BUG=723944

Review-Url: https://codereview.chromium.org/2913033003
Cr-Original-Commit-Position: refs/heads/master@{#478022}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef17b2caaf8074034c714d759ac5...
Review-Url: https://codereview.chromium.org/2913033003
Cr-Commit-Position: refs/heads/master@{#478116}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa0a64440d8045e9ee0962ed1a1d...
==========

[commit-bot: I haz the power, 2017-06-08 23:05:07]

Committed patchset #9 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/aa0a64440d8045e9ee0962ed1a1d...