Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2926043002: Rename PlainText::end() to PlainText::End() (Closed)

Created:
3 years, 6 months ago by Shanmuga Pandi
Modified:
3 years, 6 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PlainText::end() to PlainText::End() This patch renames |PlainText::end()| to |PlainText::End()| to follow the blink coding style. BUG=728524 Review-Url: https://codereview.chromium.org/2926043002 Cr-Commit-Position: refs/heads/master@{#477596} Committed: https://chromium.googlesource.com/chromium/src/+/596241679d74362580facc364ce3c5d658a2a7cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 18 chunks +40 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebRange.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Shanmuga Pandi
PTAL!!
3 years, 6 months ago (2017-06-07 07:15:36 UTC) #2
tkent
yosin@ should be the primary reviewer.
3 years, 6 months ago (2017-06-07 07:18:29 UTC) #6
yosin_UTC9
lgtm Thanks for doing this!
3 years, 6 months ago (2017-06-07 07:37:09 UTC) #7
tkent
WebRange.cpp lgtm
3 years, 6 months ago (2017-06-07 07:53:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926043002/1
3 years, 6 months ago (2017-06-07 09:26:23 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 09:30:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/596241679d74362580facc364ce3...

Powered by Google App Engine
This is Rietveld 408576698