Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

Issue 2926043002: Rename PlainText::end() to PlainText::End() (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PlainTextRange.cpp
diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
index 2a7f62a5c2cd06c86b695a223cf7bb6d2b16bed7..849d7e4d817c015c5f46f1b219d66d78b977bc1d 100644
--- a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
@@ -97,7 +97,7 @@ EphemeralRange PlainTextRange::CreateRangeFor(const ContainerNode& scope,
bool found_start =
Start() >= doc_text_position && Start() <= doc_text_position + len;
bool found_end =
- end() >= doc_text_position && end() <= doc_text_position + len;
+ End() >= doc_text_position && End() <= doc_text_position + len;
// Fix textRunRange->endPosition(), but only if foundStart || foundEnd,
// because it is only in those cases that textRunRange is used.
@@ -137,12 +137,12 @@ EphemeralRange PlainTextRange::CreateRangeFor(const ContainerNode& scope,
if (found_end) {
if (text_run_start_position.ComputeContainerNode()->IsTextNode()) {
- int offset = end() - doc_text_position;
+ int offset = End() - doc_text_position;
result_end =
Position(text_run_start_position.ComputeContainerNode(),
offset + text_run_start_position.OffsetInContainerNode());
} else {
- if (end() == doc_text_position)
+ if (End() == doc_text_position)
result_end = text_run_start_position;
else
result_end = text_run_end_position;
@@ -156,7 +156,7 @@ EphemeralRange PlainTextRange::CreateRangeFor(const ContainerNode& scope,
if (!start_range_found)
return EphemeralRange();
- if (length() && end() > doc_text_position) { // end() is out of bounds
+ if (length() && End() > doc_text_position) { // End() is out of bounds
result_end = text_run_end_position;
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/PlainTextRange.h ('k') | third_party/WebKit/Source/core/exported/WebRange.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698