DescriptionDon't use webmediaplayer to FullscreenController about fullscreen change
This is cloned from https://codereview.chromium.org/275163002/
The previous change will break webview because AwWebContentsDelegate::ToggleFullscreenModeForTab is not implemented.
This change passes a runtime switch to blink to disable fullscreen for non-media elements for android webview.
when AwWebContentsDelegate::ToggleFullscreenModeForTab is called, android webview will send a FullscreenChanged IPC to finish the will/DidEnterFullscreen event for the media element.
blink side CL: https://codereview.chromium.org/290643005/
This CL only impacts android webview
BUG=367346
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281781
Patch Set 1 #Patch Set 2 : removing content switch #
Total comments: 6
Patch Set 3 : default is_fullscreen_ to false #Patch Set 4 : addressing boliu's comments #
Total comments: 2
Patch Set 5 : removing the fullscreenchanged IPC #
Total comments: 4
Patch Set 6 : use WasResized() instead of FullscreenChanged() #Patch Set 7 : Fix testOnShowAndHideCustomViewWithJavascript #Patch Set 8 : rebase #Messages
Total messages: 36 (0 generated)
|