Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 275163002: Don't use webmediaplayer to inform webview about fullscreen change (Closed)

Created:
6 years, 7 months ago by qinmin
Modified:
6 years, 7 months ago
Reviewers:
trchen
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Don't use webmediaplayer to inform webview about fullscreen change Currently we rely on webmediaplayer to inform webview about fullscreen change. With https://codereview.chromium.org/277823002/, we no longer need to do so. When entering fullscreen, the page will be resized to fullscreen, and that will call Will/DidEnterFullscreen for us. When leaving the fullscreen, ToggleFullscreenForTab() will request the tab to exit fullscreen. That should trigger the Resize() call and send Will/DidExitFullscreen for us. BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270005

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M content/browser/media/android/browser_media_player_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qinmin
PTAL
6 years, 7 months ago (2014-05-09 18:51:24 UTC) #1
trchen
On 2014/05/09 18:51:24, qinmin wrote: > PTAL lgtm. verified manually that we no longer send ...
6 years, 7 months ago (2014-05-12 21:11:37 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 7 months ago (2014-05-12 23:17:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/275163002/20001
6 years, 7 months ago (2014-05-12 23:19:24 UTC) #4
commit-bot: I haz the power
Change committed as 270005
6 years, 7 months ago (2014-05-13 03:55:52 UTC) #5
qinmin
6 years, 7 months ago (2014-05-13 17:43:50 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/281803002/ by qinmin@chromium.org.

The reason for reverting is: this will break webview due to poor support of
fullscreen api.

Powered by Google App Engine
This is Rietveld 408576698