Don't use webmediaplayer to FullscreenController about fullscreen change

content/public/browser/render_view_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 
 #include <list>
 
 #include "base/callback_forward.h"
@@ skipping 205 matching lines @@
   // Notify the render view host to select the word around the caret.
   virtual void SelectWordAroundCaret() = 0;
 
 #if defined(OS_ANDROID)
   // Selects and zooms to the find result nearest to the point (x,y)
   // defined in find-in-page coordinates.
   virtual void ActivateNearestFindResult(int request_id, float x, float y) = 0;
 
   // Asks the renderer to send the rects of the current find matches.
   virtual void RequestFindMatchRects(int current_version) = 0;
+
+  // The page has entered or exited a fullscreen state.
+  virtual void FullscreenChanged() = 0;

[jam, 2014/06/16 20:09:06]

why add this method to RVH when all it does is call RWH::WasResized() which is
public? i.e. just have the calling code call WasResized()

[boliu, 2014/06/16 20:12:45]

I asked for it in the review because it made no sense to call WasResized from
webview code where it's clearly *not* resized. WasResized does more than just
updating the size. It also handles the full screen state, and that's the bit
webview is interested in.

[jam, 2014/06/16 22:44:16]

I don't understand what you mean. This code adds a new method to RVH that just
calls WasResized(). So I don't see how that's different from calling WasResized
directly?

Unless I'm missing something above, please just use WasResized. Especially since
RVH is going away as part of site isolation, while RWH is not.

[qinmin, 2014/06/16 23:16:18]

Done. Reverting back to WasResized() now.

On 2014/06/16 22:44:16, jam wrote:

 #endif
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderViewHostImpl;
   RenderViewHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_