Don't use webmediaplayer to FullscreenController about fullscreen change

android_webview/native/aw_web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_web_contents_delegate.h"
 
 #include "android_webview/browser/aw_javascript_dialog_manager.h"
 #include "android_webview/browser/find_helper.h"
 #include "android_webview/native/aw_contents.h"
 #include "android_webview/native/aw_contents_io_thread_client_impl.h"
@@ skipping 29 matching lines @@
 const int kFileChooserModeOpenMultiple = 1 << 0;
 const int kFileChooserModeOpenFolder = 1 << 1;
 
 base::LazyInstance<AwJavaScriptDialogManager>::Leaky
     g_javascript_dialog_manager = LAZY_INSTANCE_INITIALIZER;
 }
 
 AwWebContentsDelegate::AwWebContentsDelegate(
     JNIEnv* env,
     jobject obj)
     : WebContentsDelegateAndroid(env, obj) {

[boliu, 2014/05/27 21:45:50]

initialize is_fullscreen_

[qinmin, 2014/05/28 17:53:39]

Done.

 }
 
 AwWebContentsDelegate::~AwWebContentsDelegate() {
 }
 
 content::JavaScriptDialogManager*
 AwWebContentsDelegate::GetJavaScriptDialogManager() {
   return g_javascript_dialog_manager.Pointer();
 }
 
@@ skipping 139 matching lines @@
     callback.Run(content::MediaStreamDevices(),
                  content::MEDIA_DEVICE_INVALID_STATE,
                  scoped_ptr<content::MediaStreamUI>().Pass());
     return;
   }
   aw_contents->GetPermissionRequestHandler()->SendRequest(
       scoped_ptr<AwPermissionRequestDelegate>(
           new MediaAccessPermissionRequest(request, callback)));
 }
 
+void AwWebContentsDelegate::ToggleFullscreenModeForTab(
+    content::WebContents* web_contents, bool enter_fullscreen) {
+  is_fullscreen_ = enter_fullscreen;
+  web_contents->GetRenderViewHost()->WasResized();

[boliu, 2014/05/27 21:45:50]

So why is this needed now but not before?

Why is WasResized the right response?

Shouldn't we wait until the webview is actually resized instead of sending a
fake resize signal?

[qinmin, 2014/05/28 17:53:39]

Android webview will never get resized because it does not support fullscreen
API.
With https://codereview.chromium.org/290643005/, this call will only be called
when video goes fullscreen.
We call WasResized() to inform RenderViewHost to send an IPC to the renderer
with fullscreen flag set to true (size doesn't change, but the fullscreen flag
changed when RenderViewHost calls IsFullscreenForTabOrPending())


On 2014/05/27 21:45:50, boliu (OOO_back_June_10) wrote:

[boliu, 2014/06/11 16:16:28]

This API is so wrong though. The method should be called
GetRenderViewHost::FullscreenChanged, which internally calls WasResized. Or
maybe RVH should keep the state and have SetFullscreen(bool).

With a name like WasResized, someone could accidentally remove the fullscreen
bit and not notice until later.

[qinmin, 2014/06/13 01:47:31]

Ok, changed to use a separate IPC to inform the renderer that fullscreen state
has changed.

On 2014/06/11 16:16:28, boliu wrote:

+}
+
+bool AwWebContentsDelegate::IsFullscreenForTabOrPending(
+    const content::WebContents* web_contents) const {
+  return is_fullscreen_;
+}
+
+
 static void FilesSelectedInChooser(
     JNIEnv* env, jclass clazz,
     jint process_id, jint render_id, jint mode_flags,
     jobjectArray file_paths) {
   content::RenderViewHost* rvh = content::RenderViewHost::FromID(process_id,
                                                                  render_id);
   if (!rvh)
     return;
 
   std::vector<std::string> file_path_str;
@@ skipping 20 matching lines @@
   DVLOG(0) << "File Chooser result: mode = " << mode
            << ", file paths = " << JoinString(file_path_str, ":");
   rvh->FilesSelectedInChooser(files, mode);
 }
 
 bool RegisterAwWebContentsDelegate(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android_webview