Cleanup TextDirection

Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1] https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubidi.h?type=cs&q=UBiDiDirection&l=419
[2] https://google.github.io/styleguide/cppguide.html#Function_Names

Review-Url: https://codereview.chromium.org/2925293003
Cr-Commit-Position: refs/heads/master@{#478707}
Committed: https://chromium.googlesource.com/chromium/src/+/3b243ddca222fb1533dd1dcc29a6dfc07986d756

[kojii, 2017-06-09 10:14:42]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 10:14:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-09 12:11:32]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 12:11:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-09 12:22:08]

Description was changed from

==========
dir

BUG=
==========

to

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[1] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

[kojii, 2017-06-09 12:23:40]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2017-06-09 12:23:41]

PTAL. WDYT?

#2-4 are minor, I'm ok either way if you heard anyone expressed preferences
before.

[kojii, 2017-06-09 12:27:26]

Description was changed from

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[1] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

to

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignment in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1]
https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ub...
[2] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

[kojii, 2017-06-09 12:27:36]

Description was changed from

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignment in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1]
https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ub...
[2] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

to

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1]
https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ub...
[2] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

[kojii, 2017-06-09 12:32:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 12:32:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-06-09 12:47:32]

lgtm

[drott, 2017-06-09 12:47:46]

works for me, no objections.

[commit-bot: I haz the power, 2017-06-09 14:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 14:15:12]

Dry run: This issue passed the CQ dry run.

[eae, 2017-06-12 16:45:18]

LGTM

[eae, 2017-06-12 16:45:42]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-06-12 16:46:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 19:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497285942191530,
"parent_rev": "f9a943815c55bf468a284b474a0617c5c0e2f01d", "commit_rev":
"3b243ddca222fb1533dd1dcc29a6dfc07986d756"}

[commit-bot: I haz the power, 2017-06-12 19:06:04]

Description was changed from

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1]
https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ub...
[2] https://google.github.io/styleguide/cppguide.html#Function_Names
==========

to

==========
Cleanup TextDirection

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1]
https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ub...
[2] https://google.github.io/styleguide/cppguide.html#Function_Names

Review-Url: https://codereview.chromium.org/2925293003
Cr-Commit-Position: refs/heads/master@{#478707}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b243ddca222fb1533dd1dcc29a6...
==========

[commit-bot: I haz the power, 2017-06-12 19:06:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3b243ddca222fb1533dd1dcc29a6...