third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp - Issue 2925293003: Cleanup TextDirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

Issue 2925293003: Cleanup TextDirection (Closed)

Patch Set: unsigned to uint8_t Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

index de43cd7a6b5a632e75277ddddd620579d7b90f98..52deaf8c399e5956d65014d112c7a42feb9a3b84 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

@@ -578,7 +578,7 @@ static CSSValueID DetermineTextDirection(DocumentFragment* vtt_root) {

node = NodeTraversal::Next(*node);

}

- return IsLeftToRightDirection(text_direction) ? CSSValueLtr : CSSValueRtl;

+ return IsLtr(text_direction) ? CSSValueLtr : CSSValueRtl;

}

float VTTCue::CalculateComputedTextPosition() const {

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/LengthBox.cpp » ('j') | no next file with comments »