Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

Issue 2925293003: Cleanup TextDirection (Closed)
Patch Set: unsigned to uint8_t Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
index 06c97f96bce3f5f4c6e07f4ad182927f2aff11f4..d45cba62b1302b753681de94e15657a5491299b1 100644
--- a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
+++ b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
@@ -95,15 +95,15 @@ LayoutUnit LayoutRectOutsets::After(WritingMode writing_mode) const {
LayoutUnit LayoutRectOutsets::Start(WritingMode writing_mode,
TextDirection direction) const {
if (IsHorizontalWritingMode(writing_mode))
- return IsLeftToRightDirection(direction) ? left_ : right_;
- return IsLeftToRightDirection(direction) ? top_ : bottom_;
+ return IsLtr(direction) ? left_ : right_;
+ return IsLtr(direction) ? top_ : bottom_;
}
LayoutUnit LayoutRectOutsets::end(WritingMode writing_mode,
TextDirection direction) const {
if (IsHorizontalWritingMode(writing_mode))
- return IsLeftToRightDirection(direction) ? right_ : left_;
- return IsLeftToRightDirection(direction) ? bottom_ : top_;
+ return IsLtr(direction) ? right_ : left_;
+ return IsLtr(direction) ? bottom_ : top_;
}
LayoutUnit LayoutRectOutsets::Over(WritingMode writing_mode) const {
@@ -152,12 +152,12 @@ void LayoutRectOutsets::SetStart(WritingMode writing_mode,
TextDirection direction,
LayoutUnit value) {
if (IsHorizontalWritingMode(writing_mode)) {
- if (IsLeftToRightDirection(direction))
+ if (IsLtr(direction))
left_ = value;
else
right_ = value;
} else {
- if (IsLeftToRightDirection(direction))
+ if (IsLtr(direction))
top_ = value;
else
bottom_ = value;
@@ -168,12 +168,12 @@ void LayoutRectOutsets::SetEnd(WritingMode writing_mode,
TextDirection direction,
LayoutUnit value) {
if (IsHorizontalWritingMode(writing_mode)) {
- if (IsLeftToRightDirection(direction))
+ if (IsLtr(direction))
right_ = value;
else
left_ = value;
} else {
- if (IsLeftToRightDirection(direction))
+ if (IsLtr(direction))
bottom_ = value;
else
top_ = value;

Powered by Google App Engine
This is Rietveld 408576698