third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp - Issue 2925293003: Cleanup TextDirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp

Issue 2925293003: Cleanup TextDirection (Closed)

Patch Set: unsigned to uint8_t Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/LengthBox.cpp ('k') | third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp

index a96adcb29fb268630002a53c65b3932197070266..382a102190c18cdf4e9fcd9a39afe3cd10b4201e 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp

@@ -291,9 +291,8 @@ float ShapeResultBloberizer::FillFastHorizontalGlyphs(

auto results = result_buffer.results_;

for (unsigned i = 0; i < results.size(); ++i) {

- const auto& word_result = IsLeftToRightDirection(text_direction)

- ? results[i]

- : results[results.size() - 1 - i];

+ const auto& word_result =

+ IsLtr(text_direction) ? results[i] : results[results.size() - 1 - i];

advance = FillFastHorizontalGlyphs(word_result.Get(), advance);

}