Issue 292433008: Allows unboxed doubles to be disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292433008: Allows unboxed doubles to be disabled. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allows unboxed doubles to be disabled. This helps to support ARMv5TE. Also adds asserts to ensure that neon and vfp instructions are not generated when those features are disabled on ARM. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36262

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1295 lines, -991 lines)			Patch
M	runtime/vm/assembler_arm.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View		30 chunks	+138 lines, -28 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1	15 chunks	+627 lines, -513 lines	0 comments	Download
M	runtime/vm/constants_arm.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/cpu_arm.h	View		5 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/cpu_arm.cc	View		6 chunks	+39 lines, -9 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View	1	5 chunks	+22 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		23 chunks	+87 lines, -17 lines	0 comments	Download
M	runtime/vm/instructions_arm.cc	View		11 chunks	+21 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		10 chunks	+12 lines, -29 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+159 lines, -143 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.h	View		2 chunks	+0 lines, -38 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1	15 chunks	+104 lines, -184 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		4 chunks	+26 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zra

6 years, 7 months ago (2014-05-16 17:18:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36262 (presubmit successful).

Expand Messages | Collapse Messages