Allows unboxed doubles to be disabled.

runtime/vm/intermediate_language_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/cpu.h"
@@ skipping 272 matching lines @@
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   locs->set_out(0, Location::RequiresFpuRegister());
   locs->set_temp(0, Location::RequiresRegister());
   return locs;
 }
 
 
 void UnboxedConstantInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   // The register allocator drops constant definitions that have no uses.
   if (!locs()->out(0).IsInvalid()) {
-    if (Utils::DoublesBitEqual(Double::Cast(value()).value(), 0.0)) {
+    if (Utils::DoublesBitEqual(Double::Cast(value()).value(), 0.0) &&
+        TargetCPUFeatures::neon_supported()) {
       const QRegister dst = locs()->out(0).fpu_reg();
       __ veorq(dst, dst, dst);
     } else {
       const DRegister dst = EvenDRegisterOf(locs()->out(0).fpu_reg());
       const Register temp = locs()->temp(0).reg();
       __ LoadDImmediate(dst, Double::Cast(value()).value(), temp);
     }
   }
 }
 
@@ skipping 1765 matching lines @@
       __ TryAllocate(compiler->double_class(),
                      slow_path->entry_label(),
                      temp,
                      temp2);
       __ Bind(slow_path->exit_label());
       __ MoveRegister(temp2, temp);
       __ StoreIntoObject(instance_reg,
                          FieldAddress(instance_reg, offset_in_bytes_),
                          temp2);
       __ Bind(&copy_double);
-      __ LoadDFromOffset(fpu_temp,
-                         value_reg,
-                         Double::value_offset() - kHeapObjectTag);
-      __ StoreDToOffset(fpu_temp,
-                        temp,
-                        Double::value_offset() - kHeapObjectTag);
+      __ CopyDoubleField(temp, value_reg, TMP, temp2, fpu_temp);
       __ b(&skip_store);
     }
 
     {
       __ Bind(&store_float32x4);
       Label copy_float32x4;
       StoreInstanceFieldSlowPath* slow_path =
           new StoreInstanceFieldSlowPath(this, compiler->float32x4_class());
       compiler->AddSlowPathCode(slow_path);
 
       __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes_));
       __ CompareImmediate(temp,
                           reinterpret_cast<intptr_t>(Object::null()));
       __ b(&copy_float32x4, NE);
 
       __ TryAllocate(compiler->float32x4_class(),
                      slow_path->entry_label(),
                      temp,
                      temp2);
       __ Bind(slow_path->exit_label());
       __ MoveRegister(temp2, temp);
       __ StoreIntoObject(instance_reg,
                          FieldAddress(instance_reg, offset_in_bytes_),
                          temp2);
       __ Bind(&copy_float32x4);
-      __ LoadMultipleDFromOffset(fpu_temp, 2, value_reg,
-          Float32x4::value_offset() - kHeapObjectTag);
-      __ StoreMultipleDToOffset(fpu_temp, 2, temp,
-          Float32x4::value_offset() - kHeapObjectTag);
+      __ CopyFloat32x4Field(temp, value_reg, TMP, temp2, fpu_temp);
       __ b(&skip_store);
     }
 
     {
       __ Bind(&store_float64x2);
       Label copy_float64x2;
       StoreInstanceFieldSlowPath* slow_path =
           new StoreInstanceFieldSlowPath(this, compiler->float64x2_class());
       compiler->AddSlowPathCode(slow_path);
 
       __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes_));
       __ CompareImmediate(temp,
                           reinterpret_cast<intptr_t>(Object::null()));
       __ b(&copy_float64x2, NE);
 
       __ TryAllocate(compiler->float64x2_class(),
                      slow_path->entry_label(),
                      temp,
                      temp2);
       __ Bind(slow_path->exit_label());
       __ MoveRegister(temp2, temp);
       __ StoreIntoObject(instance_reg,
                          FieldAddress(instance_reg, offset_in_bytes_),
                          temp2);
       __ Bind(&copy_float64x2);
-      __ LoadMultipleDFromOffset(fpu_temp, 2, value_reg,
-          Float64x2::value_offset() - kHeapObjectTag);
-      __ StoreMultipleDToOffset(fpu_temp, 2, temp,
-          Float64x2::value_offset() - kHeapObjectTag);
+      __ CopyFloat64x2Field(temp, value_reg, TMP, temp2, fpu_temp);
       __ b(&skip_store);
     }
 
     __ Bind(&store_pointer);
   }
 
   if (ShouldEmitStoreBarrier()) {
     Register value_reg = locs()->in(1).reg();
     __ StoreIntoObject(instance_reg,
                        FieldAddress(instance_reg, offset_in_bytes_),
@@ skipping 321 matching lines @@
           : LocationSummary::kCallOnSlowPath);
 
   locs->set_in(0, Location::RequiresRegister());
 
   if (IsUnboxedLoad() && opt) {
     locs->AddTemp(Location::RequiresRegister());
   } else if (IsPotentialUnboxedLoad()) {
     locs->AddTemp(opt ? Location::RequiresFpuRegister()
                       : Location::FpuRegisterLocation(Q1));
     locs->AddTemp(Location::RequiresRegister());
+    locs->AddTemp(Location::RequiresRegister());
   }
   locs->set_out(0, Location::RequiresRegister());
   return locs;
 }
 
 
 void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
-  Register instance_reg = locs()->in(0).reg();
+  const Register instance_reg = locs()->in(0).reg();
   if (IsUnboxedLoad() && compiler->is_optimizing()) {
     const DRegister result = EvenDRegisterOf(locs()->out(0).fpu_reg());
     const Register temp = locs()->temp(0).reg();
     __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes()));
     const intptr_t cid = field()->UnboxedFieldCid();
     switch (cid) {
       case kDoubleCid:
         __ Comment("UnboxedDoubleLoadFieldInstr");
         __ LoadDFromOffset(result, temp,
                            Double::value_offset() - kHeapObjectTag);
@@ skipping 10 matching lines @@
         break;
       default:
         UNREACHABLE();
     }
     return;
   }
 
   Label done;
   Register result_reg = locs()->out(0).reg();
   if (IsPotentialUnboxedLoad()) {
+    const DRegister value = EvenDRegisterOf(locs()->temp(0).fpu_reg());
     const Register temp = locs()->temp(1).reg();
-    const DRegister value = EvenDRegisterOf(locs()->temp(0).fpu_reg());
+    const Register temp2 = locs()->temp(2).reg();
 
     Label load_pointer;
     Label load_double;
     Label load_float32x4;
     Label load_float64x2;
 
     __ LoadObject(result_reg, Field::ZoneHandle(field()->raw()));
 
     FieldAddress field_cid_operand(result_reg, Field::guarded_cid_offset());
     FieldAddress field_nullability_operand(result_reg,
@@ skipping 26 matching lines @@
       __ Bind(&load_double);
       BoxDoubleSlowPath* slow_path = new BoxDoubleSlowPath(this);
       compiler->AddSlowPathCode(slow_path);
 
       __ TryAllocate(compiler->double_class(),
                      slow_path->entry_label(),
                      result_reg,
                      temp);
       __ Bind(slow_path->exit_label());
       __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes()));
-      __ LoadDFromOffset(value, temp, Double::value_offset() - kHeapObjectTag);
-      __ StoreDToOffset(value,
-                        result_reg,
-                        Double::value_offset() - kHeapObjectTag);
+      __ CopyDoubleField(result_reg, temp, TMP, temp2, value);
       __ b(&done);
     }
 
     {
       __ Bind(&load_float32x4);
       BoxFloat32x4SlowPath* slow_path = new BoxFloat32x4SlowPath(this);
       compiler->AddSlowPathCode(slow_path);
 
       __ TryAllocate(compiler->float32x4_class(),
                      slow_path->entry_label(),
                      result_reg,
                      temp);
       __ Bind(slow_path->exit_label());
       __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes()));
-      __ LoadMultipleDFromOffset(value, 2, temp,
-          Float32x4::value_offset() - kHeapObjectTag);
-      __ StoreMultipleDToOffset(value, 2, result_reg,
-          Float32x4::value_offset() - kHeapObjectTag);
+      __ CopyFloat32x4Field(result_reg, temp, TMP, temp2, value);
       __ b(&done);
     }
 
     {
       __ Bind(&load_float64x2);
       BoxFloat64x2SlowPath* slow_path = new BoxFloat64x2SlowPath(this);
       compiler->AddSlowPathCode(slow_path);
 
       __ TryAllocate(compiler->float64x2_class(),
                      slow_path->entry_label(),
                      result_reg,
                      temp);
       __ Bind(slow_path->exit_label());
       __ ldr(temp, FieldAddress(instance_reg, offset_in_bytes()));
-      __ LoadMultipleDFromOffset(value, 2, temp,
-          Float64x2::value_offset() - kHeapObjectTag);
-      __ StoreMultipleDToOffset(value, 2, result_reg,
-          Float64x2::value_offset() - kHeapObjectTag);
+      __ CopyFloat64x2Field(result_reg, temp, TMP, temp2, value);
       __ b(&done);
     }
 
     __ Bind(&load_pointer);
   }
   __ LoadFromOffset(kWord, result_reg,
                     instance_reg, offset_in_bytes() - kHeapObjectTag);
   __ Bind(&done);
 }
 
@@ skipping 3662 matching lines @@
   compiler->GenerateCall(token_pos(),
                          &label,
                          PcDescriptors::kOther,
                          locs());
   __ Drop(ArgumentCount());  // Discard arguments.
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM