Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: runtime/vm/disassembler_arm.cc

Issue 292433008: Allows unboxed doubles to be disabled. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/cpu_arm.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_arm.cc
===================================================================
--- runtime/vm/disassembler_arm.cc (revision 36258)
+++ runtime/vm/disassembler_arm.cc (working copy)
@@ -6,7 +6,9 @@
#include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
#if defined(TARGET_ARCH_ARM)
+
#include "platform/assert.h"
+#include "vm/cpu.h"
namespace dart {
@@ -694,6 +696,12 @@
}
} else if (instr->IsMultiplyOrSyncPrimitive()) {
if (instr->Bit(24) == 0) {
+ if ((TargetCPUFeatures::arm_version() != ARMv7) &&
+ (instr->Bits(21, 3) != 0)) {
+ // mla ... smlal only supported on armv7.
+ Unknown(instr);
+ return;
+ }
// multiply instructions
switch (instr->Bits(21, 3)) {
case 0: {
@@ -757,7 +765,11 @@
// 16-bit immediate loads, msr (immediate), and hints
switch (instr->Bits(20, 5)) {
case 16: {
- Format(instr, "movw'cond 'rd, #'imm4_12");
+ if (TargetCPUFeatures::arm_version() == ARMv7) {
+ Format(instr, "movw'cond 'rd, #'imm4_12");
+ } else {
+ Unknown(instr);
+ }
break;
}
case 18: {
@@ -769,7 +781,11 @@
break;
}
case 20: {
- Format(instr, "movt'cond 'rd, #'imm4_12");
+ if (TargetCPUFeatures::arm_version() == ARMv7) {
+ Format(instr, "movt'cond 'rd, #'imm4_12");
+ } else {
+ Unknown(instr);
+ }
break;
}
default: {
@@ -948,6 +964,10 @@
void ARMDecoder::DecodeType3(Instr* instr) {
if (instr->IsDivision()) {
+ if (!TargetCPUFeatures::integer_division_supported()) {
+ Unknown(instr);
+ return;
+ }
if (instr->Bit(21)) {
Format(instr, "udiv'cond 'rn, 'rs, 'rm");
} else {
« no previous file with comments | « runtime/vm/cpu_arm.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698