Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2922803003: Move most scripting-related methods from WebFrame to WebLocalFrame. (Closed)

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, dcheng, dglazkov+blink, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move most scripting-related methods from WebFrame to WebLocalFrame. All callers were already calling through WebLocalFrame. No intended behavior change. BUG=416660 Review-Url: https://codereview.chromium.org/2922803003 Cr-Commit-Position: refs/heads/master@{#478452} Committed: https://chromium.googlesource.com/chromium/src/+/be6445469de9d55cbed8ad2cddb6ac204116214d

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebasing... #

Patch Set 4 : Rebasing... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -125 lines) Patch
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.h View 1 2 3 4 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebRemoteFrameImpl.cpp View 1 2 3 4 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 2 3 4 2 chunks +0 lines, -57 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 2 3 4 2 chunks +54 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (27 generated)
Łukasz Anforowicz
dcheng@, can you PTAL?
3 years, 6 months ago (2017-06-07 21:56:17 UTC) #18
dcheng
lgtm
3 years, 6 months ago (2017-06-07 22:38:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922803003/80001
3 years, 6 months ago (2017-06-09 23:22:54 UTC) #28
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 23:28:23 UTC) #31
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/be6445469de9d55cbed8ad2cddb6...

Powered by Google App Engine
This is Rietveld 408576698