Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.

Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.

BUG=416660
Review-Url: https://codereview.chromium.org/2923053002
Cr-Commit-Position: refs/heads/master@{#478436}
Committed: https://chromium.googlesource.com/chromium/src/+/df18ba76b072e6d64772f722d3bbe966f293bdda

[Łukasz Anforowicz, 2017-06-05 22:55:03]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 22:55:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 23:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:31:42]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Łukasz Anforowicz, 2017-06-05 23:45:47]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:46:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 02:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 02:08:11]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-06 18:29:16]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-06 18:29:17]

dcheng@, can you PTAL?

[dcheng, 2017-06-06 19:57:17]

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/ext...
File extensions/renderer/extension_helper.cc (right):

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/ext...
extensions/renderer/extension_helper.cc:71: if
(!render_view()->GetWebView()->MainFrame()->IsWebLocalFrame()) {
Is this actually something we need to handle? I don't quite understand when this
helper is installed.

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
File extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
(right):

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc:349:
window = frame->ToWebLocalFrame()->MainWorldScriptContext()->Global();
Perhaps we should provide a WebFrame getter to get the global proxy; wdyt?

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:247:
guest_proxy_window = guest_proxy_frame->ToWebRemoteFrame()->GlobalProxy();
Since it would be used here (and a couple other places) as well.

https://codereview.chromium.org/2923053002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebLocalFrame.h (right):

https://codereview.chromium.org/2923053002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebLocalFrame.h:24: class Function;
I think we only need v8::Local and Context for now... but I think it would
better to just #include "v8/include/v8.h".

[Łukasz Anforowicz, 2017-06-07 20:34:57]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[Łukasz Anforowicz, 2017-06-07 20:35:08]

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/ext...
File extensions/renderer/extension_helper.cc (right):

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/ext...
extensions/renderer/extension_helper.cc:71: if
(!render_view()->GetWebView()->MainFrame()->IsWebLocalFrame()) {
On 2017/06/06 19:57:17, dcheng wrote:
> Is this actually something we need to handle? I don't quite understand when
this
> helper is installed.

Good point - ExtensionMsg_AppWindowClosed is sent from
AppWindowContentsImpl::NativeWindowClosed and always targets the non-swapped-out
RenderView.  So - I've changed the above into a DCHECK.

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
File extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
(right):

https://codereview.chromium.org/2923053002/diff/40001/extensions/renderer/gue...
extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc:349:
window = frame->ToWebLocalFrame()->MainWorldScriptContext()->Global();
On 2017/06/06 19:57:17, dcheng wrote:
> Perhaps we should provide a WebFrame getter to get the global proxy; wdyt?

Yes - thank you for noticing this cleanup opportunity.

As part of this work, I've removed the TODO(lazyboy,nasko) comments, but
honestly I am not sure if I understand those comments fully.  I hope the removal
of the comments was the right thing to do.

https://codereview.chromium.org/2923053002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebLocalFrame.h (right):

https://codereview.chromium.org/2923053002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebLocalFrame.h:24: class Function;
On 2017/06/06 19:57:17, dcheng wrote:
> I think we only need v8::Local and Context for now... but I think it would
> better to just #include "v8/include/v8.h".

Done (here and also in WebFrame.h which would otherwise require
forward-declaring v8::Object for GlobalProxy method's return type).

[commit-bot: I haz the power, 2017-06-07 20:35:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:10:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2017-06-07 21:15:23]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 21:15:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:36:37]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Łukasz Anforowicz, 2017-06-07 21:37:23]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 21:37:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 23:56:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 23:56:44]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-08 17:33:27]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 17:33:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 19:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 19:39:18]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-06-08 19:46:20]

lgtm

[Łukasz Anforowicz, 2017-06-08 19:59:36]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-08 19:59:59]

The CQ bit was unchecked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:00:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-08 20:00:29]

lukasza@chromium.org changed reviewers:
+ avi@chromium.org

[Łukasz Anforowicz, 2017-06-08 20:00:30]

avi@, can you PTAL?

[Avi (use Gerrit), 2017-06-09 18:37:25]

lgtm

https://codereview.chromium.org/2923053002/diff/100001/content/shell/test_run...
File content/shell/test_runner/test_runner_for_specific_view.cc (right):

https://codereview.chromium.org/2923053002/diff/100001/content/shell/test_run...
content/shell/test_runner/test_runner_for_specific_view.cc:684: }
👍

[Łukasz Anforowicz, 2017-06-09 18:46:21]

lukasza@chromium.org changed reviewers:
+ lfg@chromium.org, rdevlin.cronin@chromium.org

[Łukasz Anforowicz, 2017-06-09 18:46:22]

+rdevlin.cronin@ for //extensions
+lfg@ for //components/guest_view (and possibly extensions/renderer/guest_view)

PTAL?

[lfg, 2017-06-09 18:53:14]

lgtm with nit.

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:239:
// TODO(lazyboy,nasko): The WebLocalFrame branch is not used when running
Please remove the comment.

[Łukasz Anforowicz, 2017-06-09 18:56:17]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[Łukasz Anforowicz, 2017-06-09 18:56:26]

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:239:
// TODO(lazyboy,nasko): The WebLocalFrame branch is not used when running
On 2017/06/09 18:53:14, lfg wrote:
> Please remove the comment.

Ooops.  Done.

[Devlin, 2017-06-09 18:56:39]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2017-06-09 18:56:40]

Most of //extensions lgtm, but +lazyboy@ knows the guest view stuff better than
I do, so I'll let him take a quick look.

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
File extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
(left):

https://codereview.chromium.org/2923053002/diff/100001/extensions/renderer/gu...
extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc:346: // on
top of out-of-process iframes. Remove it once the code is converted.
Is isolate extensions sufficient for this, or does this need to wait for full
isolation?

[commit-bot: I haz the power, 2017-06-09 18:56:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 19:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 19:00:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2017-06-09 19:31:24]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 19:31:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lazyboy, 2017-06-09 20:23:16]

lgtm

[Łukasz Anforowicz, 2017-06-09 20:30:22]

Thanks for the reviews!

[Łukasz Anforowicz, 2017-06-09 20:30:30]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-09 20:30:34]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-09 20:30:35]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
dcheng@chromium.org, lfg@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2923053002/#ps140001
(title: "Rebasing...")

[commit-bot: I haz the power, 2017-06-09 20:31:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 22:24:32]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497040234484020,
"parent_rev": "1bb4d98b866875041d80b5134eff3e64529382d5", "commit_rev":
"df18ba76b072e6d64772f722d3bbe966f293bdda"}

[commit-bot: I haz the power, 2017-06-09 22:24:45]

Description was changed from

==========
Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.

BUG=416660
==========

to

==========
Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.

BUG=416660

Review-Url: https://codereview.chromium.org/2923053002
Cr-Commit-Position: refs/heads/master@{#478436}
Committed:
https://chromium.googlesource.com/chromium/src/+/df18ba76b072e6d64772f722d3bb...
==========

[commit-bot: I haz the power, 2017-06-09 22:24:48]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/df18ba76b072e6d64772f722d3bb...